-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation warning to Changelog and documentation for setup.template.type
#28618
Add deprecation warning to Changelog and documentation for setup.template.type
#28618
Conversation
setup.template.type
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you already add it to the code? If yes, change LGTM.
that loads {ref}/index-templates.html[index templates]. | ||
Further options: `legacy`, {ref}/indices-templates-v1.html[legacy index templates] before Elasticsearch v7.8. | ||
Use this to avoid breaking existing deployments. | ||
And `component`, selecting it loads a component template which can be included in index templates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm still confused on what exactly the component template feature will do but this is not related to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation is in #28538, this is the missing docs.
Regarding the component index template, no need to worry about it because it is going to be removed in 8.0.0 :)
What does this PR do?
This PR adds more details to the option
setup.template.type
. The change is also added to the list of deprecated things in the changelog.Why is it important?
The changes in Beats have to be documented for our users. It was missing from the original PR.
Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.