Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade github.com/Microsoft/go-winio #28464

Closed
wants to merge 2 commits into from

Conversation

ChrsMark
Copy link
Member

Part of #28023

@ChrsMark ChrsMark added needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team v7.16.0 labels Oct 15, 2021
@ChrsMark ChrsMark requested a review from narph October 15, 2021 10:49
@ChrsMark ChrsMark self-assigned this Oct 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 15, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2021

This pull request does not have a backport label. Could you fix it @ChrsMark? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 15, 2021
Copy link
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the build is green then you can go ahead

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 15, 2021

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-25T11:57:12.683+0000

  • Duration: 21 min 16 sec

  • Commit: c0ee156

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

Steps errors 2

Expand to view the steps failures

make check-default
  • Took 2 min 37 sec . View more details here
  • Description: make check-default
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'hudson.AbortException: script returned exit code 2'

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@ChrsMark
Copy link
Member Author

/test

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update_go_winio_lib upstream/update_go_winio_lib
git merge upstream/master
git push upstream update_go_winio_lib

@ChrsMark
Copy link
Member Author

@kvch This CI failure looks weird, any thoughts on why this update of NOTICE file is so big and is failing?

@ChrsMark ChrsMark mentioned this pull request Oct 25, 2021
6 tasks
@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update_go_winio_lib upstream/update_go_winio_lib
git merge upstream/master
git push upstream update_go_winio_lib

@ChrsMark
Copy link
Member Author

Closing as it's already upgraded by #28621

@ChrsMark ChrsMark closed this Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants