-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix modified go.sum issue in beat generators #28375
Fix modified go.sum issue in beat generators #28375
Conversation
There were two issues: `go mod download` was run after the newly generated beat was committed. This modified the go.sum because it adds hashes for the downloaded dependencies. The caused `mage check` to fail because the git project has pending changes. The dependencies of package_test.go were missing from go.sum. When running `mage testPackages` it was failing because github.com/blakesmith/ar and github.com/cavaliercoder/go-rpm were missing.
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
/test generator |
* Fix modified go.sum issue in beat generators There were two issues: `go mod download` was run after the newly generated beat was committed. This modified the go.sum because it adds hashes for the downloaded dependencies. The caused `mage check` to fail because the git project has pending changes. The dependencies of package_test.go were missing from go.sum. When running `mage testPackages` it was failing because github.com/blakesmith/ar and github.com/cavaliercoder/go-rpm were missing. * Re-enable generator tests Relates #28361 (cherry picked from commit 81f32e7)
* Fix modified go.sum issue in beat generators There were two issues: `go mod download` was run after the newly generated beat was committed. This modified the go.sum because it adds hashes for the downloaded dependencies. The caused `mage check` to fail because the git project has pending changes. The dependencies of package_test.go were missing from go.sum. When running `mage testPackages` it was failing because github.com/blakesmith/ar and github.com/cavaliercoder/go-rpm were missing. * Re-enable generator tests Relates #28361 (cherry picked from commit 81f32e7) Co-authored-by: Andrew Kroh <[email protected]>
* Fix modified go.sum issue in beat generators There were two issues: `go mod download` was run after the newly generated beat was committed. This modified the go.sum because it adds hashes for the downloaded dependencies. The caused `mage check` to fail because the git project has pending changes. The dependencies of package_test.go were missing from go.sum. When running `mage testPackages` it was failing because github.com/blakesmith/ar and github.com/cavaliercoder/go-rpm were missing. * Re-enable generator tests Relates elastic#28361
What does this PR do?
There were two issues:
go mod download
was run after the newly generated beat was committed. This modified the go.sum because itadds hashes for the downloaded dependencies. The caused
mage check
to fail because the git project haspending changes.
The dependencies of package_test.go were missing from go.sum. When running
mage testPackages
itwas failing because github.com/blakesmith/ar and github.com/cavaliercoder/go-rpm were missing.
Why is it important?
CI is failing in the generator tests. This was failing when Go 1.17.1 was updated in #27543 (comment).
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
PLATFORMS=linux/amd64 make -C generator/_templates/beat test test-package
Issues
Logs