-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port IncludeAnnotations setting to Agent and small manifest fix #28247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <[email protected]>
ChrsMark
added
Team:Integrations
Label for the Integrations team
backport-v7.16.0
Automated backport with mergify
labels
Oct 5, 2021
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Oct 5, 2021
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Oct 5, 2021
ChrsMark
changed the title
Port IncludeAnnotations setting to Agent and small mainfest fix
Port IncludeAnnotations setting to Agent and small manifest fix
Oct 5, 2021
Signed-off-by: chrismark <[email protected]>
Collaborator
x-pack/elastic-agent/pkg/composable/providers/kubernetes/kubernetes.go
Outdated
Show resolved
Hide resolved
x-pack/elastic-agent/pkg/composable/providers/kubernetes/node.go
Outdated
Show resolved
Hide resolved
x-pack/elastic-agent/pkg/composable/providers/kubernetes/pod.go
Outdated
Show resolved
Hide resolved
x-pack/elastic-agent/pkg/composable/providers/kubernetes/service.go
Outdated
Show resolved
Hide resolved
MichaelKatsoulis
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor cosmetic updates.
6 tasks
…netes.go Co-authored-by: Michael Katsoulis <[email protected]>
Co-authored-by: Michael Katsoulis <[email protected]>
Co-authored-by: Michael Katsoulis <[email protected]>
…ce.go Co-authored-by: Michael Katsoulis <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Oct 5, 2021
(cherry picked from commit a690364)
ChrsMark
added a commit
that referenced
this pull request
Oct 5, 2021
…) (#28254) (cherry picked from commit a690364) Co-authored-by: Chris Mark <[email protected]>
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Small followup fix related to #27691:
kubernetes.pod.labels.app == redis
to ``kubernetes.labels.app == redis`IncludeAnnotations
How to test this PR manually
Using the following redis Pod:
Test the following scenarios:
kubernetes.namespace_annotations.foo == bar
kubectl annotate ns default foo=bar