-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] gcp: respect Beats naming conventions #27974
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
@kaiyan-sheng I was expecting tests to fail due to the rename. As the are all green I'm confused. |
Pinging @elastic/integrations (Team:Integrations) |
@endorama I think it's because only |
This pull request is now in conflicts. Could you fix it? 🙏
|
@endorama Are you planning to add |
@kaiyan-sheng I was planning to at least try to do that, so I was able to test these changes. But it's taking a lot of time and I'm still facing some strange errors. |
@kaiyan-sheng dashboards updated |
(cherry picked from commit 5375f0a) # Conflicts: # metricbeat/docs/fields.asciidoc
(cherry picked from commit 5375f0a) # Conflicts: # metricbeat/docs/fields.asciidoc
(cherry picked from commit 5375f0a) # Conflicts: # metricbeat/docs/fields.asciidoc Co-authored-by: endorama <[email protected]>
After we aligned metrics with Beats naming convention (elastic#27974) the docs has not been adequately updated.
Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit 923e11f) # Conflicts: # x-pack/metricbeat/module/gcp/dataproc/_meta/docs.asciidoc # x-pack/metricbeat/module/gcp/firestore/_meta/docs.asciidoc
Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit 923e11f)
…es after #27974 (#33080) Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: Edoardo Tenani <[email protected]>
…ies after #27974 (#33079) Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: Edoardo Tenani <[email protected]> Co-authored-by: Edoardo Tenani <[email protected]>
Co-authored-by: DeDe Morton <[email protected]>
What does this PR do?
Changes fiels exported by all GCP metricset to adhere to ECS and Beats naming conventions.
This PR flattens all fields definition, to help correlating the mapping between GCP Monitoring and ECS fields.
The remapping operation is performed as a
map[string]string
lookup on a manually built map mapping the GCP Monitoring metric name to the appropriate ECS field.Why is it important?
We want our metricset to adhere to ECS and Beats naming convention, so the data exported is easily consumed in Elasticsearch.
As 7.16 is the last minor before 8.0 and must be compatible with 8.0 is the last chance to introduce these breaking changes.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs