Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated kafka fields #27938

Merged
merged 4 commits into from
Sep 20, 2021
Merged

Remove deprecated kafka fields #27938

merged 4 commits into from
Sep 20, 2021

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Sep 15, 2021 •
edited
Loading

Remove deprecated fields for 8.0, and alias fields used during 7.0 ECS
migration.

Part of #13911.

@jsoriano
Remove deprecated kafka fields
b698469 
Remove deprecated fields for 8.0, and alias fields used during 7.0 ECS
migration.
@jsoriano jsoriano added the Team:Integrations Label for the Integrations team label Sep 15, 2021
@jsoriano jsoriano self-assigned this Sep 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 15, 2021
@jsoriano jsoriano mentioned this pull request Sep 15, 2021
Closed
19 tasks
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 15, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-20T07:50:22.464+0000

  • Duration: 101 min 14 sec

  • Commit: 7e36988

Test stats 🧪

Test Results
Failed 0
Passed 24444
Skipped 4734
Total 29178

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 24444
Skipped 4734
Total 29178

mtojek
mtojek reviewed Sep 15, 2021
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you need to adjust Go logic as well:

Exception: Key 'kafka.partition.topic.name' found in event is not documented!

@jsoriano
Copy link
Member Author

jsoriano commented Sep 15, 2021 •
edited
Loading

I suppose you need to adjust Go logic as well:

Exception: Key 'kafka.partition.topic.name' found in event is not documented!

Umm, it worked on my computer ™️ I guess I had some spurious fields.yml around.

@jsoriano jsoriano requested a review from mtojek September 15, 2021 16:25
@jsoriano jsoriano merged commit 085fd3e into elastic:master Sep 20, 2021
@jsoriano jsoriano deleted the remove-deprecated-kafka-fields branch September 20, 2021 11:36
v1v added a commit to v1v/beats that referenced this pull request Sep 20, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/e2e-fleet
10d1617 
* upstream/master: (658 commits)
  Add complete k8s metadata through composable provider (elastic#27691)
  Revert "Fix issue where --insecure didn't propogate to Fleet Server ES connection (elastic#27969)" (elastic#27997)
  Remove deprecated kafka fields (elastic#27938)
  [Filebeat] Add Base64 encoded HMAC & UUID template functions to httpjson input (elastic#27873)
  Improve httpjson template function join (elastic#27996)
  Remove kubernetes.container.image alias (elastic#27898)
  [Elastic Agent] Golden files for program tests (elastic#27862)
  [Elastic Agent] Disable modules.d in metricbeat (elastic#27860)
  libbeat/common/seccomp: provide default policy for linux arm64 (elastic#27955)
  Fix logger statement in aws-s3 input (elastic#27982)
  Fix wrong merge (elastic#27976)
  Fix issue where --insecure didn't propogate to Fleet Server ES connection (elastic#27969)
  Forward-port 7.14.2 changelog to master (elastic#27975)
  [Filebeat] Removing duplicate modules (aliases) Observability (elastic#27919)
  Fix path in vagrant windows script (elastic#27966)
  [Filebeat] Removing duplicate modules (aliases) and Cyberark (elastic#27915)
  No changelog for 8.0.0-alpha2 (elastic#27961)
  Add write access to 'url.value' from 'request.transforms'. (elastic#27937)
  Docker: remove deprecated fields (elastic#27933)
  Filebeat: Make all filesets disabled in default configuration (elastic#27762)
  ...
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@jsoriano
Remove deprecated kafka fields (elastic#27938)
c0363c9 
Remove deprecated fields for 8.0, and alias fields used during 7.0 ECS
migration.
@jsoriano jsoriano mentioned this pull request Mar 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@jsoriano jsoriano

Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoriano @elasticmachine @mtojek