-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Heartbeat] Setuid to regular user / lower capabilities when possible #27878
Merged
+1,095
−103
Merged
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
88d2d1d
Checkpoint
andrewvc 66d2e6b
Checkpoint
andrewvc f050f79
Checkpoint
andrewvc dbe92db
Add comment
andrewvc 7413b0e
Fix unncessary changes
andrewvc 0d791d9
Fix unncessary changes
andrewvc 992a3c6
Cleanup
andrewvc f938856
Add license override
andrewvc 58ef9a3
Be more particular
andrewvc b295517
Tweaks
andrewvc 206b346
Checkpoint
andrewvc 576ca31
Checkpoint
andrewvc 7e26638
Checkpoint
andrewvc 61ae19c
SECCOMP Checkpoint
andrewvc fa24f7e
More fixes
andrewvc 61542a0
Cleanup and fixes
andrewvc eaadc02
More fixes
andrewvc 2835b98
CHANGELOG
andrewvc faa0989
More tweaks
andrewvc 84d7eac
Rename seccomp->security
andrewvc ddbbf6e
Fix overrides
andrewvc 1623137
Fix seccomp.go
andrewvc e1799f6
Cleanup
andrewvc 94f95e4
Merge remote-tracking branch 'origin/master' into root-caps
andrewvc bf90094
Fix lint
andrewvc d055eb7
Fix lint
andrewvc 7ba5301
separate setcaps
andrewvc f757217
Apply security to regular heartbeat too
andrewvc 9b7c6e6
Only lookup groups etc. on linux
andrewvc 793214e
Use simpler logic
andrewvc 0aa410c
Fix lint
andrewvc c9532f3
Make portable to win/darwin
andrewvc cee1ad6
Fix setcap notation
andrewvc de41310
Make debugging build failure simpler
andrewvc 3cafd9c
Merge branch 'master' into root-caps
mergify[bot] 1ad68d3
Merge branch 'master' into root-caps
mergify[bot] 7cddfa8
Merge branch 'master' into root-caps
mergify[bot] 1a90113
Only target linux x86/amd64
andrewvc 9dcd749
Merge branch 'root-caps' of github.com:andrewvc/beats into root-caps
andrewvc 735aa76
Merge remote-tracking branch 'origin/master' into root-caps
andrewvc ea805d9
Fix setcap syntax
andrewvc 0a292ee
Fix extra trailing slash
andrewvc bdc4c19
Fix setcap
andrewvc 6a49b88
Follow link for setcap
andrewvc 64a9d9e
fix
andrewvc c55cd77
Finalize
andrewvc 7c2fc33
Merge remote-tracking branch 'origin/master' into root-caps
andrewvc d5da29c
Remove stdout
andrewvc 39218ae
Incorporate PR feedback
andrewvc 393bd27
Merge remote-tracking branch 'origin/master' into root-caps
andrewvc 70fcce6
Update heartbeat security
andrewvc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Checkpoint
commit f050f79263a2c6462b4c6107a78985c871074820
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we call this just
LOCAL_USER
? I assume it could apply to any subprocess, it does not have to be a Beat? OrLOCAL_USER_SUBPROCESS
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've renamed it to
BEAT_SETUID_AS
I think it should be obscure and not something with any risk of clashing.