Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.15](backport #26952) Adding functionality to death letter index instead of dropping events. #27838

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 9, 2021

This is an automatic backport of pull request #26952 done by Mergify.
Cherry-pick of 60cf09d has failed:

On branch mergify/bp/7.15/pr-26952
Your branch is up to date with 'origin/7.15'.

You are currently cherry-picking commit 60cf09dcfc.
  (all conflicts fixed: run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

nothing to commit, working tree clean

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

Adding functionality to death letter index instead of dropping events.

When there's a mapping conflict events are dropped, this commits allows one attempting to index it into a different index instead so it can be re-ingested later vs dropping or stalling ingest. The index currently must reside on the same ES cluster.

* buildCollectPublishFails and other functions changed to be a function of Client so not to have to pass arguments

Co-authored-by: Noémi Ványi <[email protected]>
(cherry picked from commit 60cf09d)
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Sep 9, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 9, 2021
@botelastic
Copy link

botelastic bot commented Sep 9, 2021

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-09T13:03:13.769+0000

  • Duration: 16 min 8 sec

  • Commit: 316d423

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@jsoriano jsoriano requested a review from kvch September 13, 2021 16:53
@kvch
Copy link
Contributor

kvch commented Sep 14, 2021

This PR is empty, the changes have already been backported a month ago.

@kvch kvch closed this Sep 14, 2021
@mergify mergify bot deleted the mergify/bp/7.15/pr-26952 branch September 14, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants