Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metricbeat, fix metricsets log level behavior #27804

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

philippkahr
Copy link
Contributor

@philippkahr philippkahr commented Sep 8, 2021

What does this PR do?

Until now errors in the metric sets were only reported as INFO. If someone configures metricbeat to only write a log file on error, issues like cannot connect to Elasticsearch 404, 400 Bad request could be missed.

Why is it important?

  • Easier debugging
  • If metricbeat cannot connect it is an error and should be classified as such a thing.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 8, 2021
@botelastic
Copy link

botelastic bot commented Sep 8, 2021

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-08T09:29:31.836+0000

  • Duration: 124 min 59 sec

  • Commit: 553e2c3

Test stats 🧪

Test Results
Failed 0
Passed 17639
Skipped 2768
Total 20407

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 17639
Skipped 2768
Total 20407

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@jsoriano jsoriano added the backport-v7.16.0 Automated backport with mergify label Sep 13, 2021
@jsoriano jsoriano merged commit 6af8ffb into elastic:master Sep 13, 2021
mergify bot pushed a commit that referenced this pull request Sep 13, 2021
@philippkahr philippkahr deleted the fix-log-levels-in-metricsets branch September 13, 2021 18:57
jsoriano pushed a commit that referenced this pull request Sep 15, 2021
(cherry picked from commit 6af8ffb)

Co-authored-by: Philipp Kahr <[email protected]>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.16.0 Automated backport with mergify needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metricbeat metric sets modules uses wrong log level
3 participants