Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override region according to bucket location #27695

Merged
merged 3 commits into from
Sep 3, 2021
Merged

Override region according to bucket location #27695

merged 3 commits into from
Sep 3, 2021

Conversation

aspacca
Copy link

@aspacca aspacca commented Sep 1, 2021

Enhancement

What does this PR do?

Allows to ingest logs from aws-s3 bucket listing input regardless of the region used in the aws profile

Why is it important?

https://github.com/elastic/observability-test-plans/issues/232#issuecomment-910333796

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 1, 2021
@aspacca aspacca added backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify Team:Integrations Label for the Integrations team labels Sep 1, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 1, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-02T15:44:48.241+0000

  • Duration: 91 min 26 sec

  • Commit: be62a9c

Test stats 🧪

Test Results
Failed 0
Passed 8142
Skipped 1201
Total 9343

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8142
Skipped 1201
Total 9343

@kaiyan-sheng
Copy link
Contributor

Sorry I forgot one thing: should we update the aws-s3 documentation to include a new permission for GetBucketLocation?

@aspacca aspacca merged commit bf68823 into elastic:master Sep 3, 2021
mergify bot pushed a commit that referenced this pull request Sep 3, 2021
* Override region according to bucket location

* added integration test for getRegionForBucketARN

* update docs on iam permissions

(cherry picked from commit bf68823)
mergify bot pushed a commit that referenced this pull request Sep 3, 2021
* Override region according to bucket location

* added integration test for getRegionForBucketARN

* update docs on iam permissions

(cherry picked from commit bf68823)
aspacca pushed a commit that referenced this pull request Sep 3, 2021
* Override region according to bucket location

* added integration test for getRegionForBucketARN

* update docs on iam permissions

(cherry picked from commit bf68823)

Co-authored-by: Andrea Spacca <[email protected]>
aspacca pushed a commit that referenced this pull request Sep 3, 2021
* Override region according to bucket location

* added integration test for getRegionForBucketARN

* update docs on iam permissions

(cherry picked from commit bf68823)

Co-authored-by: Andrea Spacca <[email protected]>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
* Override region according to bucket location

* added integration test for getRegionForBucketARN

* update docs on iam permissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants