-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doc build issues happening in linux/memory #27381
Fix doc build issues happening in linux/memory #27381
Conversation
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Is there any reason this has not been backported to 7.x? I'm seeing the same issues on my 7.x backport (docs being updated when executed on a mac, etc). |
* fix doc build issues * add changelog * move tests to linux-only (cherry picked from commit b906aab)
* fix doc build issues * add changelog * move tests to linux-only (cherry picked from commit b906aab) Co-authored-by: Alex K <[email protected]>
What does this PR do?
This fixes an issue reported by @faec . Because the main .go file for linux/memory had a build constraint, targets like
makeUpdate
were changing the docs on non-linux platforms. This wasn't breaking CI, but it was annoying. This shuffles around the files so we don't need the build constraints anymore.Why is it important?
This was annoying for people developing on darwin/windows.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.