Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc build issues happening in linux/memory #27381

Merged

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Aug 13, 2021

What does this PR do?

This fixes an issue reported by @faec . Because the main .go file for linux/memory had a build constraint, targets like makeUpdate were changing the docs on non-linux platforms. This wasn't breaking CI, but it was annoying. This shuffles around the files so we don't need the build constraints anymore.

Why is it important?

This was annoying for people developing on darwin/windows.

Checklist

  • My code follows the style guidelines of this project
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@fearful-symmetry fearful-symmetry added bug Team:Integrations Label for the Integrations team labels Aug 13, 2021
@fearful-symmetry fearful-symmetry requested a review from a team August 13, 2021 22:37
@fearful-symmetry fearful-symmetry self-assigned this Aug 13, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 13, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 13, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-16T16:02:14.886+0000

  • Duration: 85 min 6 sec

  • Commit: 2bd02ac

Test stats 🧪

Test Results
Failed 0
Passed 9084
Skipped 2416
Total 11500

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9084
Skipped 2416
Total 11500

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@fearful-symmetry fearful-symmetry merged commit b906aab into elastic:master Aug 16, 2021
@kovyrin
Copy link
Contributor

kovyrin commented Oct 1, 2021

Is there any reason this has not been backported to 7.x? I'm seeing the same issues on my 7.x backport (docs being updated when executed on a mac, etc).

@fearful-symmetry fearful-symmetry added the backport-v7.16.0 Automated backport with mergify label Oct 1, 2021
mergify bot pushed a commit that referenced this pull request Oct 1, 2021
* fix doc build issues

* add changelog

* move tests to linux-only

(cherry picked from commit b906aab)
fearful-symmetry added a commit that referenced this pull request Oct 1, 2021
* fix doc build issues

* add changelog

* move tests to linux-only

(cherry picked from commit b906aab)

Co-authored-by: Alex K <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.16.0 Automated backport with mergify bug Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants