-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backwards compatibility with Golang 1.13.x to support Google Cloud Functions #27012
Conversation
Pinging @elastic/agent (Team:Agent) |
Is there a chance we can reduce the amount of copy and paste code? |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That change hurts. I still see why it is supported for GCP support :(
Hi! We're labeling this issue as |
This pull request is now in conflicts. Could you fix it? 🙏
|
New temp fix: #28251 |
What does this PR do?
This PR adds backwards compatibility with Golang 1.13.x. The unsupported features were
VerifyConnections
introduced in #22495 andTLSDialContext
from #25219Why is it important?
Google Cloud Function run in Golang 1.13.8 environment. Previously, Beats only supported the version in the file
.go-version
. To make sure users can deploy and run Functionbeat on GCP these changes are required.Also, we need to include some backwards compatibility smoke test or whatever so we are not breaking GCP functions in the future.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Closes #24925