Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Update Elasticsearch Deprecation fileset parsing #26880

Merged
merged 3 commits into from
Jul 28, 2021
Merged

[Filebeat] Update Elasticsearch Deprecation fileset parsing #26880

merged 3 commits into from
Jul 28, 2021

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Jul 14, 2021 •
edited
Loading

What does this PR do?

Update the ingest pipelines for the Elasticsearch's deprecation logs.

Why is it important?

The current pipelines are parsing incorrectly or dropping events due to changes in the deprecation log format.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

cd beats/filebeat
TESTING_FILEBEAT_MODULES=elasticsearch TESTING_FILEBEAT_FILESETS=deprecation mage -v pythonIntegTest

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 14, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 14, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-26T15:15:42.504+0000

  • Duration: 95 min 37 sec

  • Commit: 71c2f7a

Test stats 🧪

Test Results
Failed 0
Passed 14894
Skipped 2313
Total 17207

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 14894
Skipped 2313
Total 17207

@marc-gr
Copy link
Contributor

marc-gr commented Jul 20, 2021

/test

@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 26857-elasticsearch-deprecation-logs upstream/26857-elasticsearch-deprecation-logs
git merge upstream/master
git push upstream 26857-elasticsearch-deprecation-logs

@ChrsMark ChrsMark added the Team:Integrations Label for the Integrations team label Jul 26, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 26, 2021
@marc-gr
Copy link
Contributor

marc-gr commented Jul 26, 2021

/test

@marc-gr marc-gr requested a review from jsoriano July 26, 2021 15:15
@jsoriano jsoriano added the needs_integration_sync Changes in this PR need synced to elastic/integrations. label Jul 27, 2021
jsoriano
jsoriano approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this will have to be changed in integrations too. cc @sayden

@marc-gr marc-gr added backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify labels Jul 28, 2021
@marc-gr marc-gr merged commit a25a244 into elastic:master Jul 28, 2021
mergify bot pushed a commit that referenced this pull request Jul 28, 2021
@legoguy1000
[Filebeat] Update Elasticsearch Deprecation fileset parsing (#26880)
05b6de8 
* #26857: Update Elasticsearch Deprecation fileset parsing

* update changelog

Co-authored-by: Marc Guasch <[email protected]>
(cherry picked from commit a25a244)
@mergify mergify bot mentioned this pull request Jul 28, 2021
Merged
mergify bot pushed a commit that referenced this pull request Jul 28, 2021
@legoguy1000
[Filebeat] Update Elasticsearch Deprecation fileset parsing (#26880)
570b0b5 
* #26857: Update Elasticsearch Deprecation fileset parsing

* update changelog

Co-authored-by: Marc Guasch <[email protected]>
(cherry picked from commit a25a244)
@mergify mergify bot mentioned this pull request Jul 28, 2021
Merged
@legoguy1000 legoguy1000 deleted the 26857-elasticsearch-deprecation-logs branch July 28, 2021 11:41
marc-gr pushed a commit that referenced this pull request Jul 28, 2021
@mergify @legoguy1000
[Filebeat] Update Elasticsearch Deprecation fileset parsing (#26880) (#…
ba0b72f 
…27095)

* #26857: Update Elasticsearch Deprecation fileset parsing

* update changelog

Co-authored-by: Marc Guasch <[email protected]>
(cherry picked from commit a25a244)

Co-authored-by: Alex Resnick <[email protected]>
marc-gr pushed a commit that referenced this pull request Aug 2, 2021
@legoguy1000 @marc-gr
[Filebeat] Update Elasticsearch Deprecation fileset parsing (#26880)
e13995f 
* #26857: Update Elasticsearch Deprecation fileset parsing

* update changelog

Co-authored-by: Marc Guasch <[email protected]>
(cherry picked from commit a25a244)
marc-gr pushed a commit that referenced this pull request Aug 2, 2021
@mergify @legoguy1000
[Filebeat] Update Elasticsearch Deprecation fileset parsing (#26880) (#…
f94136c 
…27096)

* #26857: Update Elasticsearch Deprecation fileset parsing

* update changelog

Co-authored-by: Marc Guasch <[email protected]>
(cherry picked from commit a25a244)

Co-authored-by: Alex Resnick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees
No one assigned
Labels
backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify needs_integration_sync Changes in this PR need synced to elastic/integrations. Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filebeat Elasticsearch module ingest pipelines fail to parse deprecation logs
5 participants
@legoguy1000 @elasticmachine @marc-gr @jsoriano @ChrsMark