Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #26524 to 7.14: [filebeat][fortinet] Use default add_locale for fortinet.firewall #26660

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Cherry-pick #26524 to 7.14: [filebeat][fortinet] Use default add_locale for fortinet.firewall #26660

merged 1 commit into from
Jul 1, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jul 1, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #26524 to 7.14 branch. Original message:

What does this PR do?

  • Adds a add_locale default processor to fortinet.firewall
  • Uses event.timezone on the ingest pipeline
  • Adds documentation about how to set a custom timezone

Why is it important?

It has been a recurrent request to be able to set a custom timezone to fortinet.firewall.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@marc-gr
[filebeat][fortinet] Use default add_locale for fortinet.firewall (el…
06857de 
…astic#26524)

* Use default add_locale for fortinet.firewall

* Use event.timezone in all date processors

(cherry picked from commit 5d258c8)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 1, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26660 opened

  • Start Time: 2021-07-01T11:46:02.085+0000

  • Duration: 119 min 43 sec

  • Commit: 06857de

Test stats 🧪

Test Results
Failed 0
Passed 14091
Skipped 2326
Total 16417

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 14091
Skipped 2326
Total 16417

@marc-gr marc-gr merged commit 119b06b into elastic:7.14 Jul 1, 2021
@marc-gr marc-gr deleted the backport_26524_7.14 branch July 1, 2021 13:59
@marc-gr marc-gr mentioned this pull request Jul 5, 2021
Closed
@zube zube bot removed the [zube]: Done label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marc-gr @elasticmachine