-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Make set processor with copy_from compatible with ES < 7.13 #26593
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
d2da7be
to
407f7c7
Compare
Automatically rewrite Ingest Node `set` processors that use `copy_from` when connected to Elasticsearch versions less than 7.13. The copy_from is replaced with `{{{$copy_from value}}}`. The triple brace ensures the behavior is the same as copy_from in that no escaping is added.
407f7c7
to
2b94416
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
I think this can break some of the usages we have: panw.panos copying an object instead of a string: beats/x-pack/filebeat/module/panw/panos/ingest/pipeline.yml Lines 465 to 468 in 895f55f
cyberarkpas.audit doing something weird I wrote: beats/x-pack/filebeat/module/cyberarkpas/audit/ingest/pipeline.yml Lines 942 to 950 in 895f55f
Do we currently run the tests on ES 7.11 by any chance? I'll rewrite those two without using copy_from. |
Thanks for raising the issue with object types. Since this solution won't work for all of the corner cases I have opened #26629 to discuss how to handle this. I had considered replace |
What does this PR do?
Automatically rewrite Ingest Node
set
processors that usecopy_from
when connected toElasticsearch versions less than 7.13. The copy_from is replaced with
{{{$copy_from value}}}
.The triple brace ensures the behavior is the same as copy_from in that no escaping is added.
Why is it important?
Ensures compatibility with earlier ES versions.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.