Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #26187 to 7.x: Add log_group_name_prefix config option for aws-cloudwatch input #26527

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Cherry-pick #26187 to 7.x: Add log_group_name_prefix config option for aws-cloudwatch input #26527

merged 1 commit into from
Jun 28, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jun 28, 2021

Cherry-pick of PR #26187 to 7.x branch. Original message:

What does this PR do?

This PR is to add log_group_name_prefix config option into aws-cloudwatch input to equivalently support wildcard for log_group_name.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

With filebeat input below, you should be able to see Filebeat starts aws-cloudwatch input to collect logs from all log groups that has names start with /aws/ecs.

filebeat.inputs:
- type: aws-cloudwatch
  credential_profile_name: elastic-beats
  log_group_name_prefix: /aws/ecs
  region_name: us-east-1

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 28, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 28, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 28, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26527 opened

  • Start Time: 2021-06-28T14:36:54.482+0000

  • Duration: 112 min 57 sec

  • Commit: 1a6bfe9

Test stats 🧪

Test Results
Failed 0
Passed 7368
Skipped 1201
Total 8569

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 7368
Skipped 1201
Total 8569

@kaiyan-sheng kaiyan-sheng merged commit c6ab0c1 into elastic:7.x Jun 28, 2021
@kaiyan-sheng kaiyan-sheng deleted the backport_26187_7.x branch June 28, 2021 16:36
@zube zube bot removed the [zube]: Done label Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants