-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Syslog input GA #26293
Make the Syslog input GA #26293
Conversation
Pinging @elastic/agent (Team:Agent) |
This pull request is now in conflicts. Could you fix it? 🙏
|
@faec good finding in the unix's socket's status, I don't know if it should still be in beta. @andrewstucki or @andrewkroh is the unix socket still a beta feature or we could remove the warning? see https://github.com/elastic/beats/blob/master/filebeat/input/syslog/config.go#L122 |
We might as well move the unix socket to GA too. I'm not aware of any reasons to hold it back from GA. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Syslog changes LGTM, is there a reason why the modules files was updated?
@faec did you look into the documentation to make sure we removed any beta mention?
I'm not sure why the modules file updated -- it was an effect of I searched the documentation and removed all the beta warnings I could find. I also removed them from the reference configs, but edited the generated files by mistake, so |
Module problem was seemingly because my local go was pointing at 1.16.4 instead of 1.16.5 when I ran |
(cherry picked from commit 4684ac7)
(cherry picked from commit 4684ac7) Co-authored-by: Fae Charlton <[email protected]>
* master: (25 commits) Fix UBI source URL (elastic#26384) Skip test_rotating_file in osx and windows (elastic#26379) Remove outdated k8s manifests for managed elastic-agent (elastic#26368) Enable agent to send custom headers to kibana/ES (elastic#26275) [Automation] Update elastic stack version to 8.0.0-943ef2c0 for testing (elastic#26354) Make the Syslog input GA (elastic#26293) Move Kerberos FAST config flag to shared kerberos config (elastic#26141) Add k8s cluster identifiers (elastic#26056) Store message from MongoDB json logs in message field (elastic#26338) update threatintel ECS version (elastic#26274) update envoyproxy ECS version (elastic#26277) [Filebeat] [MongoDB] Support MongoDB 4.4 json logs (elastic#24774) Update go-structform to 0.0.9 (elastic#26251) Forward port 7.13.2 changelog to master (elastic#26323) Updated filter expression for filtering 86 artifacts (elastic#26313) Osquerybeat: Align with the rest of the beats, set the ECS version (elastic#26324) [Packetbeat] Add `url.extension` to Packetbeat HTTP events (elastic#25999) Change link to snapshots in README (elastic#26317) Don't include full ES index template in errors (elastic#25743) First refactor of the system module - system/cpu and system/core (elastic#25771) ...
What does this PR do?
Remove the beta warning from syslog RFC 5424 in the code and docs.
Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.