chore: pass BEAT_VERSION when running E2E tests #26291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
added
the
Team:Automation
botelastic
bot
added
needs_team
cachedout
approved these changes
Jun 14, 2021
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Log outputExpand to view the last 100 lines of log output
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
v1v
approved these changes
Jun 18, 2021
There was a problem hiding this comment.
I'm not sure if this could be done with the props file feature we added back in the days.
See #22027
In a nutshell:
- beats:Jenkinsfile generates a properties file with (git sha, beats-version...), then the downstream jobs get triggered and read the file if possible (otherwise, use the previous behaviour).
This helps to ensure the git sha and versioning is passed correctly between downstream jobs and we don't use the latest archived artifacts in the Google Storage but the specific commit id .
This process was put in place for the main-pipeline -> packaging -> beats-tester but IIRC we didn't do it for the e2e-testing
Other than that, It looks ok
I'm not sure if I follow you about that file :S What we are trying to solve is the need to get the real version behind a commit-sha: i.e. the commit |
mdelapenya
added
backport-v7.13.0
mergify bot
pushed a commit
that referenced
this pull request
Jun 23, 2021
(cherry picked from commit ea84a3b)
mergify bot
pushed a commit
that referenced
this pull request
Jun 23, 2021
(cherry picked from commit ea84a3b)
6 tasks
mdelapenya
added a commit
to mdelapenya/beats
that referenced
this pull request
Jun 28, 2021
* master: (32 commits) [Metricbeat] Change Account ID to Project ID in `gcp.billing` module (elastic#26412) update libbeat fields.ecs.yml file and ecsVersion to 1.10.0 (elastic#26121) [Filebeat] Update AWS ELB ingest pipeline (elastic#26441) [FIlebeat] add strict_date_optional_time_nanos date format to PanOS module (elastic#26158) Fix the irregular and typo on prometheus module. (elastic#25726) [Filebeat] Parse additonal debug data fields for Okta module (elastic#25818) fix: update MSSQL Server linux image's Docker registry (elastic#26440) Update indexing.go godocs (elastic#26408) Do not close filestream harvester if an unexpected error is returned when close.on_state_change.* is enabled (elastic#26411) Add support for copytruncate method when rotating input logs with an external tool in `filestream` input (elastic#23457) Allow fields with ip_range datatype (elastic#26444) Add Anomali ThreatStream support to threatintel module (elastic#26350) fix: use the right param type (elastic#26469) [Automation] Update elastic stack version to 8.0.0-7640093f for testing (elastic#26460) Set SM Filebeat modules as GA (elastic#26226) Fix rfc5464 date parsing in the syslog input (elastic#26419) Add linked account information into billing metricset (elastic#26285) [Filebeat] Update HA Proxy log grok patterns (elastic#25835) disable metricbeat logstash test_node_stats (elastic#26436) chore: pass BEAT_VERSION when running E2E tests (elastic#26291) ...
v1v
pushed a commit
that referenced
this pull request
Jul 14, 2021
(cherry picked from commit ea84a3b) Co-authored-by: Manuel de la Peña <[email protected]>
v1v
pushed a commit
that referenced
this pull request
Jul 14, 2021
(cherry picked from commit ea84a3b) Co-authored-by: Manuel de la Peña <[email protected]>
|
@Mergifyio backport 7.14 |
mergify bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
(cherry picked from commit ea84a3b)
|
Command
|
mdelapenya
added a commit
that referenced
this pull request
Sep 22, 2021
…6889) * chore: pass BEAT_VERSION when running E2E tests (#26291) (cherry picked from commit ea84a3b) * fix: proper param type Co-authored-by: Jaime Soriano Pastor <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]>
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…) (elastic#26889) * chore: pass BEAT_VERSION when running E2E tests (elastic#26291) (cherry picked from commit b35a1bf) * fix: proper param type Co-authored-by: Jaime Soriano Pastor <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It passes the BEAT_VERSION to the downstream execution of the E2E tests:
Why is it important?
In elastic/e2e-testing#1256, the e2e are adding the ability of using the expected version for a Beat. We want to adhere to that contract
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist