Docker module for Metricbeat #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ruflin
force-pushed
the
mb-docker-module
branch
2 times, most recently
from
1ea0d6d to
acdcaf7
Compare
|
@douaejeouit I took again the most recent version of your branch and applied to changes. I still not sure on what goes wrong on your side. Instead of spending time to figure out this issue I suggest we are going ahead with this branch here and merge it. As soon as it is in master, we can start iterate on top of it and the changes will be much smaller and easier to debug. WDYT? |
All credit for this module goes to @douaejeouit and Ingensi. See elastic#2444
ruflin
force-pushed
the
mb-docker-module
branch
from
acdcaf7 to
60d4eb2
Compare
|
@ruflin Ok, it sounds good to me 🎉 !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All credit for this module goes to @douaejeouit and Ingensi. See elastic#2444