-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run go mod donwload too when checking for changes #26241
Conversation
Pinging @elastic/integrations (Team:Integrations) |
❕ Build Aborted
Expand to view the summary
Build stats
Trends 🧪Log outputExpand to view the last 100 lines of log output
|
Pinging @elastic/agent (Team:Agent) |
@michel-laterman Can you have a look? Does this change play well with the update to go 1.16.5 here #26186 (If I understand correctly 1.16.5 does revert some changes on go.sum handling). |
@jsoriano The repo was updated to 1.16.5. Is the change still required? |
The specific change to the makefile was not part of my update, so this might still be needed |
This change doesn't seem to be needed anymore, |
💔 Build Failed
Expand to view the summary
Build stats
Trends 🧪Steps errorsExpand to view the steps failures
|
go mod download
has to be executed also aftergo mod tidy
inmake check-no-changes
to be consistent withmake notice
.Both commands can result on different
go.sum
since go 1.16 (golang/go#43994 (comment)).Issue found when trying to update govmomi in #26167,
make notice
generated ago.sum
that mademake check-no-changes
to fail.