Osquerybeat: Rewrite queries scheduling with extensions for scheduling and logging #25641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksmaus
added
enhancement
7.14 Candidate
backport-v7.14.0
aleksmaus
requested review from
urso,
scunningham,
lykkin,
patrykkopycinski and
james-elastic
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
🎉
|
/test |
scunningham
approved these changes
May 13, 2021
| bt *osquerybeat | ||
| } | ||
|
|
||
| func (a *actionHandler) Name() string { |
There was a problem hiding this comment.
requires pointer? not important, just curious
There was a problem hiding this comment.
it is passed into the agent client as interface so will escape to the heap no matter what, and it's only allocated once
| } | ||
|
|
||
| func actionDataFromRequest(req map[string]interface{}) (ad actionData, err error) { | ||
| if req == nil { |
x-pack/osquerybeat/beater/install.go
Outdated
| exedir := filepath.Dir(exefp) | ||
|
|
||
| // Install osqueryd if needed | ||
| err = installOsqueryWithDir(ctx, exedir) |
There was a problem hiding this comment.
return installOsqueryWithDir(ctx, exedir) ?
|
/test |
mergify bot
pushed a commit
that referenced
this pull request
May 14, 2021
…g and logging (#25641) * Osquerybeat: Rewrite queries scheduling with extensions for scheduling and logging * Make check happy * Update notice, to make linter happy * Fix Go 1.16 check failure, when calling t.Fatal from goroutine * Fix windows build * Add configuration plugin tests * Add logger plugin unit tests * Rollback gotest_test change * Address code review comments (cherry picked from commit c1a3a8d) # Conflicts: # go.mod
aleksmaus
added a commit
that referenced
this pull request
May 17, 2021
…xtensions for scheduling and logging (#25722) * Osquerybeat: Rewrite queries scheduling with extensions for scheduling and logging (#25641) * Osquerybeat: Rewrite queries scheduling with extensions for scheduling and logging * Make check happy * Update notice, to make linter happy * Fix windows build * Add configuration plugin tests * Add logger plugin unit tests * Rollback gotest_test change * Address code review comments (cherry picked from commit c1a3a8d) # Conflicts: # go.mod * Resolve conflict Co-authored-by: Aleksandr Maus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why is it important?
Addresses https://github.com/elastic/security-team/issues/1061
Checklist
Related issues
Screenshots
The
osquery_scheduleis now populated with the scheduled queries statsThe scheduled queries and ad-hoc queries are working as expected