Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #25446 to 7.13: Allow role_arn work with access keys for AWS #25504

Merged
merged 1 commit into from
May 4, 2021
Merged

Cherry-pick #25446 to 7.13: Allow role_arn work with access keys for AWS #25504

merged 1 commit into from
May 4, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented May 3, 2021

Cherry-pick of PR #25446 to 7.13 branch. Original message:

What does this PR do?

This PR is to change role_arn config option to work not only with given credential profile but also access keys. With this change, aws integration will be able to use role_arn without volume mounting the credential profile file.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

With IAM role test-role setup, config below should work:

metricbeat.modules:
- module: aws
  period: 5m
  access_key_id: xxx
  secret_access_key: yyy
  role_arn: arn:aws:iam::1234:role/test-role
  metricsets:
    - ec2

Related issues

This PR also fixed the role_arn related documentation.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 3, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this May 3, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 3, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user kaiyan-sheng

  • Start Time: 2021-05-04T16:25:44.474+0000

  • Duration: 60 min 23 sec

  • Commit: 835594e

Test stats 🧪

Test Results
Failed 0
Passed 18887
Skipped 1585
Total 20472

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 18887
Skipped 1585
Total 20472

@kaiyan-sheng kaiyan-sheng merged commit 3cfea28 into elastic:7.13 May 4, 2021
@kaiyan-sheng kaiyan-sheng deleted the backport_25446_7.13 branch May 4, 2021 22:53
@zube zube bot removed the [zube]: Done label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants