Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Additional parsing for haproxy.http.request.raw_request_line #25482

Merged
merged 1 commit into from
May 3, 2021
Merged

[Filebeat] Additional parsing for haproxy.http.request.raw_request_line #25482

merged 1 commit into from
May 3, 2021

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Parses the haproxy.http.request.raw_request_line field into url.original,http.request.method,http.version

Why is it important?

Allows for better correlation between other logs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

cd beats/filebeat
TESTING_FILEBEAT_MODULES=haproxy mage -v pythonIntegTest

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 1, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 1, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: P1llus commented: run tests

  • Start Time: 2021-05-02T09:27:21.504+0000

  • Duration: 50 min 37 sec

  • Commit: c59eabb

Test stats 🧪

Test Results
Failed 0
Passed 735
Skipped 149
Total 884

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 735
Skipped 149
Total 884

@legoguy1000 legoguy1000 marked this pull request as ready for review May 1, 2021 19:12
@P1llus
Copy link
Member

P1llus commented May 1, 2021

run tests

@P1llus P1llus added enhancement Filebeat Filebeat Team:Integrations Label for the Integrations team labels May 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 1, 2021
P1llus
P1llus approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Checked for:
Changelog entry.
Updated golden files.
Existing field is not renamed/removed, so no breaking change.
The new ECS mappings are correct.

Would need a +1 from a observability/integrations member as well.

Will wait for CI to finish first.

@legoguy1000
Copy link
Contributor Author

Looks like some Jenkins error on the windows 7 job.

@P1llus
Copy link
Member

P1llus commented May 1, 2021

Looks like some Jenkins error on the windows 7 job.

Yeah that one is unrelated to yours, its a known issue.

Did you make this PR from the latest master?

@legoguy1000
Copy link
Contributor Author

legoguy1000 commented May 1, 2021 •
edited
Loading

Yes it is, just checked.

@P1llus
Copy link
Member

P1llus commented May 2, 2021

run tests

@legoguy1000
Copy link
Contributor Author

run tests

Looks like it worked this time.

@P1llus
Copy link
Member

P1llus commented May 2, 2021

run tests

Looks like it worked this time.

Yeah all good, just waiting for the approval from the other team.

@SHolzhauer
Copy link
Contributor

@legoguy1000 LGTM

@legoguy1000
Copy link
Contributor Author

@marc-gr @P1llus can one of you merge this if it GTG?

@P1llus P1llus merged commit 5059faa into elastic:master May 3, 2021
@P1llus
Copy link
Member

P1llus commented May 3, 2021

Can you cherry-pick this to 7.x branch @legoguy1000 ?

@legoguy1000 legoguy1000 deleted the 25480-haproxy branch May 3, 2021 14:05
@legoguy1000
Copy link
Contributor Author

Can you cherry-pick this to 7.x branch @legoguy1000 ?

sure

legoguy1000 added a commit to legoguy1000/beats that referenced this pull request May 3, 2021
@legoguy1000
elastic#25480: Additional parsing for `haproxy.http.request.raw_reque…
153280f 
…st_line` (elastic#25482)

(cherry picked from commit 5059faa)
@legoguy1000 legoguy1000 mentioned this pull request May 3, 2021
Closed
6 tasks
legoguy1000 added a commit to legoguy1000/beats that referenced this pull request May 3, 2021
@legoguy1000
elastic#25480: Additional parsing for `haproxy.http.request.raw_reque…
5f0ba5a 
…st_line` (elastic#25482)

(cherry picked from commit 5059faa)
@legoguy1000 legoguy1000 mentioned this pull request May 3, 2021
Merged
6 tasks
P1llus pushed a commit that referenced this pull request May 3, 2021
@legoguy1000
#25480: Additional parsing for haproxy.http.request.raw_request_line (
8d792d1 
#25482) (#25496)

(cherry picked from commit 5059faa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

@P1llus P1llus P1llus approved these changes

Assignees
No one assigned
Labels
enhancement Filebeat Filebeat Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Filebeat] [HaProxy] Parse http and url fields
5 participants
@legoguy1000 @elasticmachine @P1llus @SHolzhauer @marc-gr