Update documentation of filestream input with the new improvements
#25303
Conversation
* How is it different from log input? * Section about parsers * Add `ignore_inactive` option * Add `resend_on_touch` option
botelastic
bot
added
the
needs_team
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪❕ Flaky test reportNo test was executed to be analysed. |
|
LGTM. @dedemorton you want to review, or shall we progress with merging? @kvch is this doc update for 7.13? |
|
Yes, it is for 7.13. |
| aggragate the contents into a multiline event. | ||
|
|
||
| 4. Some position updates and metadata changes no longer depend on the publishing pipeline. | ||
| If a the pipeline is blocked some changes are still applied to the registry. |
There was a problem hiding this comment.
| If a the pipeline is blocked some changes are still applied to the registry. | |
| If a pipeline is blocked, some changes are still applied to the registry. |
There was a problem hiding this comment.
Not sure if a or the on this one.
There was a problem hiding this comment.
We have one pipeline per input, so I would say the.
There was a problem hiding this comment.
Did you remove the a then? It looks like it still reads "If a the pipeline..."
There was a problem hiding this comment.
See step 4 on this page: https://www.elastic.co/guide/en/beats/filebeat/master/filebeat-input-filestream.html#_parsers
|
Don't wait for me to review this. Brandon's comments are golden. |
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
kvch
added
backport-v7.13.0
…25303) (#25521) (cherry picked from commit d29e006) Co-authored-by: Noémi Ványi <[email protected]>
…25303) (#25522) (cherry picked from commit d29e006) Co-authored-by: Noémi Ványi <[email protected]>
|
I think some of my review comments were skippable, but there are a few that weren't addressed that I think still need to be. |
What does this PR do?
This PR adds more information about the
filestreaminput to our documentation. It also adds details about the newly added features of the input.See the docs preview: https://beats_25303.docs-preview.app.elstc.co/diff
Topics added & updated
parsersoptioninclude_filesoptionignore_inactiveoptionresend_on_touchoptionWhy is it important?
In the last few weeks
filestreamhas been improved immensely. The documentation has reflect the changes.Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.