Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #25132 to 7.x: Keep http and logging config during enroll #25168

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Apr 20, 2021

Cherry-pick of PR #25132 to 7.x branch. Original message:

What does this PR do?

At the moment all configuration is discarded when agent enrolls to fleet.
This PR enables persistence of settings for logging and http (exposing metrics).
Without this cloud is not able to set http endpoint and collect metrics from agent and processes

Why is it important?

Cloud

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

…25132)

[Ingest Manager] Keep http and logging config during enroll (elastic#25132)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 20, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25168 opened

  • Start Time: 2021-04-20T09:08:55.093+0000

  • Duration: 91 min 55 sec

  • Commit: bb19180

Test stats 🧪

Test Results
Failed 0
Passed 6740
Skipped 24
Total 6764

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6740
Skipped 24
Total 6764

@michalpristas michalpristas merged commit 291bbee into elastic:7.x Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants