Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for tests after device... field has been removed #25141

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Fix for tests after device... field has been removed #25141

merged 3 commits into from
Apr 19, 2021

Conversation

narph
Copy link
Contributor

@narph narph commented Apr 19, 2021

What does this PR do?

Fix for tests after device... field has been removed

Why is it important?

Fix for tests after device... field has been removed

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@narph narph requested a review from a team as a code owner April 19, 2021 13:23
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 19, 2021
kaiyan-sheng
kaiyan-sheng approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing this!

@kaiyan-sheng kaiyan-sheng mentioned this pull request Apr 19, 2021
Merged
6 tasks
@narph narph self-assigned this Apr 19, 2021
@narph narph added needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team labels Apr 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 19, 2021
jsoriano
jsoriano approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 19, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: jsoriano commented: /test

  • Start Time: 2021-04-19T18:50:16.674+0000

  • Duration: 34 min 32 sec

  • Commit: b44ec3b

Test stats 🧪

Test Results
Failed 0
Passed 746
Skipped 228
Total 974

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 746
Skipped 228
Total 974

@jsoriano
Copy link
Member

/test

@jsoriano
Copy link
Member

Tests passed, not sure why "Lint" is marked as pending. Merging to fix builds.

@jsoriano jsoriano merged commit 863c704 into elastic:master Apr 19, 2021
@jsoriano jsoriano mentioned this pull request Apr 19, 2021
Merged
@jsoriano
Copy link
Member

Removing the field from 7.x too in #25153.

@adriansr adriansr mentioned this pull request Apr 19, 2021
Closed
jsoriano added a commit that referenced this pull request Apr 20, 2021
@jsoriano
Revert "Add field for user agent device type (#24871) (#24876)" (#25153)
6fcafb7 
This reverts commit da0299a.

Field added in #24876 has been reverted in master in #25141.
v1v added a commit to v1v/beats that referenced this pull request Apr 20, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/customise…
2d9fb4d 
…-github-pr-comment-template

* upstream/master:
  [Ingest Manager] Keep http and logging config during enroll (elastic#25132)
  Refactor kubernetes autodiscover to avoid skipping short-living pods (elastic#24742)
  [libbeat] New decode xml wineventlog processor (elastic#25115)
  Add svc to agent k8s clusterRole (elastic#25146)
  Add awsfargate module to collect container logs from Amazon ECS on Fargate (elastic#25041)
  [Filebeat][Cisco ASA] log enhancement and performance (elastic#24744)
  Watch kubernetes namespaces for autodiscover metadata for pods (elastic#25117)
  Cyberark Privileged Access Security module (elastic#24803)
  [Elastic Agent] Log the container command output with LOGS_PATH (elastic#25150)
  Fix for tests after `device...` field has been removed (elastic#25141)
  [Ingest Manager] Restart process on output change (elastic#24907)
  Set --insecure in container when FLEET_SERVER_ENABLE and FLEET_INSECURE set. (elastic#25137)
  [filebeat] Update documentation / changelog / beta warnings for the syslog input (elastic#25047)
  Add support for ignore_inactive in filestream input (elastic#25036)
  Fix bug with annotations dedot config on k8s not used (elastic#25111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@jsoriano jsoriano jsoriano approved these changes

Assignees

@narph narph

Labels
needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@narph @elasticmachine @jsoriano @kaiyan-sheng