Fix panic when Hearbeat monitor initialization fails twice #25073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialization was only tried once. Second time a nil object and a nil error are returned, producing nil pointer dereferences later.
jsoriano
added
review
Team:Integrations
|
Pinging @elastic/uptime (Team:Uptime) |
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
jsoriano
added
the
needs_backport
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
14 tasks
ChrsMark
approved these changes
Apr 14, 2021
6 tasks
jsoriano
added
v7.13.0
and removed
needs_backport
Merged
6 tasks
jsoriano
added a commit
that referenced
this pull request
Apr 14, 2021
jsoriano
added a commit
that referenced
this pull request
Apr 14, 2021
v1v
added a commit
to v1v/beats
that referenced
this pull request
Apr 15, 2021
* upstream/master: packer cache support for the 7.x and 7.latestMinor branches (elastic#25091) Remove EventFetcher and EventsFetcher interface (elastic#25093) Update go-structform to 0.0.8 (elastic#25051) Update copy_fields.asciidoc (elastic#25053) [elastic-agent] ensure container is backwards compatible (elastic#25092) Add --fleet-server-service-token. Rename --fleet-server to --fleet-server-es. (elastic#25083) Add cgroup.cpuacct percentages (elastic#25057) Add tests for truncated and symlinked files in filestream input (elastic#24425) Fix panic when Hearbeat monitor initialization fails twice (elastic#25073) [Filebeat][httpjson] Change append transform to initiate new fields as a slice (elastic#25074) Osquerybeat: Result values type translation (elastic#25012) Update Osquerybeat spec to get it downloading from the correct artifactory path (elastic#25076) Fix changelog (elastic#25079) Strip Azure EventHub connection string in debug logs (elastic#25066) Change googlecloud to gcp in field names (elastic#25038) Bump stack version to 7.12.0 for testing (elastic#24957) packer-cache: cache the existing docker images on ARM and some more (elastic#25068) Disable logstash TestFetch flaky test (elastic#25044)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…5073) (elastic#25090) Initialization was only tried once. Second time a nil object and a nil error are returned, producing nil pointer dereferences later. (cherry picked from commit 841c82d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents a panic happening when ICMP initialization fails twice.
Initialization was only tried once. Second time a nil object and a nil error are returned, producing nil pointer dereferences later.
With static configurations the first failure inmediatelly stops heartbeat, so this is not a problem, but with autodiscover multiple initialization attempts may happen.
Why is it important?
Prevent unexpected panics when introducing ICMP configurations through autodiscover.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues
Logs
For the record, stack trace printed when this issue happens: