Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24426 to 7.x: Add tests for encoding setting of filestream input #24629

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Mar 18, 2021

Cherry-pick of PR #24426 to 7.x branch. Original message:

What does this PR do?

Add support for configuring encoding and adds migrates related tests from test_harvester.py.

Why is it important?

Previously encoding could not be configured correctly from configure. The underlying feature works it is already covered by numerous unit tests.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 18, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24629 opened

  • Start Time: 2021-03-18T12:51:48.671+0000

  • Duration: 75 min 48 sec

  • Commit: 795884c

Test stats 🧪

Test Results
Failed 0
Passed 13125
Skipped 2257
Total 15382

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 13125
Skipped 2257
Total 15382

@kvch kvch merged commit b571b6f into elastic:7.x Mar 18, 2021
@zube zube bot removed the [zube]: Done label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants