Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #24515 to 7.11: [Auditbeat] btmp offset check #24551

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Cherry-pick #24515 to 7.11: [Auditbeat] btmp offset check #24551

merged 1 commit into from
Mar 16, 2021

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Mar 15, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #24515 to 7.11 branch. Original message:

What does this PR do?

Adds check that saved offset is not larger than the current file size.

Why is it important?

This prevents seeking past the end of the file.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Logs

Bug report contained logs like:

  2021-03-01T10:58:05.161+0100	DEBUG	[login]	login/utmp.go:204	Reading file /var/log/btmp (utmpFile={Inode:1704287 Path:/var/log/btmp Size:1536 Offset:10752 Type:1})

@leehinman
[Auditbeat] btmp offset check (elastic#24515)
ab5199e 
* auditbeat btmp offset check

Add check that saved offset is not larger than the current file size
to prevent seeking past the end of file

(cherry picked from commit b03a935)
@leehinman leehinman requested a review from a team as a code owner March 15, 2021 17:55
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 15, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24551 opened

  • Start Time: 2021-03-15T17:57:18.142+0000

  • Duration: 31 min 58 sec

  • Commit: ab5199e

Test stats 🧪

Test Results
Failed 0
Passed 337
Skipped 145
Total 482

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 337
Skipped 145
Total 482

@leehinman leehinman merged commit 3ec3ae8 into elastic:7.11 Mar 16, 2021
@leehinman leehinman deleted the backport_24515_7.11 branch March 16, 2021 14:53
@zube zube bot removed the [zube]: Done label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leehinman @elasticmachine @marc-gr