Cherry-pick #24253 to 7.x: Make installer atomic on windows #24297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Ingest Manager] Make installer atomic on windows (elastic#24253)
michalpristas
added
bug
backport
Team:Ingest Management
Team:Elastic-Agent
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
blakerouse
approved these changes
Mar 2, 2021
| @@ -36,6 +36,8 @@ | |||
| - Windows agent doesn't uninstall with a lowercase `c:` drive in the path {pull}23998[23998] | |||
| - Fix reloading of log level for services {pull}[24055]24055 | |||
| - Fix: Successfully installed and enrolled agent running standalone{pull}[24128]24128 | |||
| - Make installer atomic on windows {pull}[24253]24253 | |||
| - Remove installed services on agent uninstall {pull}[24151]24151 | |||
There was a problem hiding this comment.
Need to fix this changelog entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #24253 to 7.x branch. Original message:
What does this PR do?
PR fixes issue on windows when on restart while installing beats we end up with partial data.
awaitable installler was introduced which forces app wait for installer finish its job
and
sync is forced for windows after rename is called during install.
Why is it important?
Fixes #24180
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.