Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24253 to 7.12: Make installer atomic on windows #24296

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Mar 2, 2021

Cherry-pick of PR #24253 to 7.12 branch. Original message:

What does this PR do?

PR fixes issue on windows when on restart while installing beats we end up with partial data.
awaitable installler was introduced which forces app wait for installer finish its job

and

sync is forced for windows after rename is called during install.

Why is it important?

Fixes #24180

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

[Ingest Manager] Make installer atomic on windows (elastic#24253)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 2, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 2, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24296 opened

  • Start Time: 2021-03-02T17:30:15.754+0000

  • Duration: 51 min 27 sec

  • Commit: 5ebb425

Test stats 🧪

Test Results
Failed 0
Passed 6500
Skipped 24
Total 6524

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6500
Skipped 24
Total 6524

Copy link
Contributor

@EricDavisX EricDavisX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed via test, on the 8.0 branch - merging to pick it up in 7.12 bc3

@EricDavisX EricDavisX merged commit d931545 into elastic:7.12 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants