Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24281 to 7.x: [Elastic Agent] Fix #24273 - Fix SIGSEGV due to missing err check #24282

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Mar 1, 2021

Cherry-pick of PR #24281 to 7.x branch. Original message:

What does this PR do?

Fixes a missing checkout for an error when performing bootstrap of Fleet Server.

Why is it important?

So proper error is reported and to not cause a SIGSEGV.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 1, 2021
@blakerouse blakerouse self-assigned this Mar 1, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24282 opened

  • Start Time: 2021-03-01T21:24:39.933+0000

  • Duration: 52 min 18 sec

  • Commit: d80cd91

Test stats 🧪

Test Results
Failed 0
Passed 6486
Skipped 24
Total 6510

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6486
Skipped 24
Total 6510

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@blakerouse blakerouse merged commit 95fe2eb into elastic:7.x Mar 2, 2021
@blakerouse blakerouse deleted the backport_24281_7.x branch March 2, 2021 13:21
@zube zube bot removed the [zube]: Done label Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants