Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix state_node conditions ' types #24241

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Fix state_node conditions ' types #24241

merged 1 commit into from
Feb 25, 2021

Conversation

ChrsMark
Copy link
Member

What does this PR do?

This PR fixes the type of kubernetes.node.status.* of state_node metricset from boolean to keyword since the value can be one of "true, false or unknown".

Fields were added at #23905

@ChrsMark ChrsMark added bug v7.13.0 v7.12.0 kubernetes Enable builds in the CI for kubernetes labels Feb 25, 2021
@ChrsMark ChrsMark requested a review from jsoriano February 25, 2021 12:48
@ChrsMark ChrsMark self-assigned this Feb 25, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 25, 2021
@botelastic
Copy link

botelastic bot commented Feb 25, 2021

This pull request doesn't have a Team:<team> label.

@ChrsMark ChrsMark mentioned this pull request Feb 25, 2021
Merged
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24241 opened

  • Start Time: 2021-02-25T12:49:53.406+0000

  • Duration: 73 min 53 sec

  • Commit: 9659641

Test stats 🧪

Test Results
Failed 0
Passed 8568
Skipped 2122
Total 10690

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8568
Skipped 2122
Total 10690

jsoriano
jsoriano approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@ChrsMark ChrsMark merged commit cdde0c7 into elastic:master Feb 25, 2021
@ChrsMark ChrsMark mentioned this pull request Feb 25, 2021
Merged
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Feb 25, 2021
@ChrsMark
Fix state_node conditions ' types (elastic#24241)
83513d7 
(cherry picked from commit cdde0c7)
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Feb 25, 2021
@ChrsMark
Fix state_node conditions ' types (elastic#24241)
09d9f77 
(cherry picked from commit cdde0c7)
@ChrsMark ChrsMark mentioned this pull request Feb 25, 2021
Merged
ChrsMark added a commit that referenced this pull request Feb 25, 2021
@ChrsMark
Fix state_node conditions ' types (#24241) (#24244)
b0de20e 
(cherry picked from commit cdde0c7)
ChrsMark added a commit that referenced this pull request Feb 25, 2021
@ChrsMark
Fix state_node conditions ' types (#24241) (#24245)
80c7cbf 
(cherry picked from commit cdde0c7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@ChrsMark ChrsMark

Labels
bug kubernetes Enable builds in the CI for kubernetes needs_team Indicates that the issue/PR needs a Team:* label v7.12.0 v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrsMark @elasticmachine @jsoriano