[Heartbeat] Report first synth error on summary #24194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes elastic/kibana#92066 Prior to this for the summary.error field for browser events we'd report the last encountered error. We now report the first. This prevents the issue where on a failing run the synthetics library considers an exit status of 1 to be an error. This will always be the case when a step fails, meaning that the last error will always be a status code error stepping on the actual step error.
botelastic
bot
added
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
andresrc
added
the
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime (Team:Uptime) |
botelastic
bot
removed
the
needs_team
blakerouse
approved these changes
Feb 24, 2021
4 tasks
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Feb 24, 2021
Fixes elastic/kibana#92066 Prior to this for the summary.error field for browser events we'd report the last encountered error. We now report the first. This prevents the issue where on a failing run the synthetics library considers an exit status of 1 to be an error. This will always be the case when a step fails, meaning that the last error will always be a status code error stepping on the actual step error. (cherry picked from commit c5821d9)
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Feb 24, 2021
Fixes elastic/kibana#92066 Prior to this for the summary.error field for browser events we'd report the last encountered error. We now report the first. This prevents the issue where on a failing run the synthetics library considers an exit status of 1 to be an error. This will always be the case when a step fails, meaning that the last error will always be a status code error stepping on the actual step error. (cherry picked from commit c5821d9)
4 tasks
andrewvc
added a commit
that referenced
this pull request
Feb 25, 2021
Fixes elastic/kibana#92066 Prior to this for the summary.error field for browser events we'd report the last encountered error. We now report the first. This prevents the issue where on a failing run the synthetics library considers an exit status of 1 to be an error. This will always be the case when a step fails, meaning that the last error will always be a status code error stepping on the actual step error. (cherry picked from commit c5821d9)
andrewvc
added a commit
that referenced
this pull request
Feb 25, 2021
Fixes elastic/kibana#92066 Prior to this for the summary.error field for browser events we'd report the last encountered error. We now report the first. This prevents the issue where on a failing run the synthetics library considers an exit status of 1 to be an error. This will always be the case when a step fails, meaning that the last error will always be a status code error stepping on the actual step error. (cherry picked from commit c5821d9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes elastic/kibana#92066
Prior to this for the summary.error field for browser events we'd report the last encountered error. We now report the first. This
prevents the issue where on a failing run the synthetics library considers an exit status of 1 to be an error. This will always be the
case when a step fails, meaning that the last error will always be a status code error stepping on the actual step error.
No changelog required because this bug should only be present in 7.12
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Run synthetics with a failing test against this branch. In the Uptime UI, on the monitor overview page, the error shown should be the first failing step.
Related issues
Use cases
Screenshots
Logs