Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24155 to 7.x: [Elastic Agent] Fix docker entrypoint for elastic-agent. #24161

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Feb 22, 2021

Cherry-pick of PR #24155 to 7.x branch. Original message:

What does this PR do?

Fixes issue caused by #23865 where the enrollment command doesn't get parameterized url and enrollment token.

Why is it important?

So enrollment through Docker works.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

* Fix docker entrypoint for elastic-agent.

* Add changelog entry.

(cherry picked from commit 239f243)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 22, 2021
@blakerouse blakerouse self-assigned this Feb 22, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24161 opened

  • Start Time: 2021-02-22T16:17:23.817+0000

  • Duration: 165 min 24 sec

  • Commit: 8c95220

Test stats 🧪

Test Results
Failed 0
Passed 46577
Skipped 4981
Total 51558

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 46577
Skipped 4981
Total 51558

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blakerouse blakerouse merged commit bd0f675 into elastic:7.x Feb 23, 2021
@blakerouse blakerouse deleted the backport_24155_7.x branch February 23, 2021 12:04
@zube zube bot removed the [zube]: Done label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants