Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supported versions file in Metricbeat module for Consul #24123

Merged
merged 5 commits into from
Mar 4, 2021
Merged

Add supported versions file in Metricbeat module for Consul #24123

merged 5 commits into from
Mar 4, 2021
+10 −5

Conversation

jsoriano
Copy link
Member

With the supported versions file, images will be cached, reducing
flakiness in CI.

Added tests with Consul 1.9.3.

@jsoriano
Add supported versions file in Metricbeat module for Consul
a9b9c09 
With the supported versions file, images will be cached, reducing
flakiness in CI.

Added tests with Consul 1.9.3.
@jsoriano jsoriano added the Team:Integrations Label for the Integrations team label Feb 19, 2021
@jsoriano jsoriano self-assigned this Feb 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 19, 2021
@jsoriano jsoriano added the needs_backport PR is waiting to be backported to other branches. label Feb 19, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 19, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: jsoriano commented: /test

  • Start Time: 2021-03-02T15:39:45.475+0000

  • Duration: 35 min 47 sec

  • Commit: 9d233af

Test stats 🧪

Test Results
Failed 0
Passed 8572
Skipped 2133
Total 10705

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8572
Skipped 2133
Total 10705

sayden
sayden approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we should add a CHANGELOG entry announcing the improved support

@jsoriano
Copy link
Member Author

jsoriano commented Mar 1, 2021

I was wondering if we should add a CHANGELOG entry announcing the improved support

Added, thanks!

@jsoriano
Copy link
Member Author

jsoriano commented Mar 2, 2021

/test

@jsoriano jsoriano merged commit 7eab148 into elastic:master Mar 4, 2021
@jsoriano jsoriano deleted the consul-supported-versions branch March 4, 2021 11:51
@jsoriano jsoriano mentioned this pull request Mar 4, 2021
Merged
@jsoriano jsoriano added v7.13.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 4, 2021
jsoriano added a commit to jsoriano/beats that referenced this pull request Mar 4, 2021
@jsoriano
Add supported versions file in Metricbeat module for Consul (elastic#…
034d88c 
…24123)

With the supported versions file, images will be cached, reducing
flakiness in CI.

Added tests with Consul 1.9.3.

(cherry picked from commit 7eab148)
jsoriano added a commit that referenced this pull request Mar 5, 2021
@jsoriano
Add supported versions file in Metricbeat module for Consul (#24123) (#…
a2adbf4 
…24347)

With the supported versions file, images will be cached, reducing
flakiness in CI.

Added tests with Consul 1.9.3.

(cherry picked from commit 7eab148)
This was referenced Mar 22, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

Assignees

@jsoriano jsoriano

Labels
Team:Integrations Label for the Integrations team v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoriano @elasticmachine @sayden