Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23905 to 7.x: [Metricbeat][Kubernetes] Extend state_node with more conditions #24057

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Feb 16, 2021

Cherry-pick of PR #23905 to 7.x branch. Original message:

What does this PR do?

This PR extends the state_node module of the Metricbeat's Kubernetes module with more status conditions, such as MemoryPressure, DiskPressure, OutOfDisk and PIDPressure.

Refactor the opFilter Prometheus metric helper to allow the declaration of multiple Metricbeat fields from a single Prometheus metric, based on allowed label values.

Why is it important?

Adding more status conditions of Kubernetes nodes is useful for monitoring and alerting purposes as it allows one to use conditions like:

  • Is any node running out of memory?
  • Is any node running out of disk?
  • Is any node running out of PIDs?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Use cases

Screenshots

Logs

2021-02-08T12:34:38.470+0200    DEBUG   [processors]    processing/processors.go:203    Publish event: {                                                                                                                                      
  "@timestamp": "2021-02-08T10:34:38.307Z",                                                                                                                                                                                                   
  "@metadata": {                                                                                                                                                                                                                              
    "beat": "metricbeat",                                                                                                                                                                                                                     
    "type": "_doc",                                                                                                                                                                                                                           
    "version": "8.0.0"                                                                                                                                                                                                                        
  },                                                                                                                                                                                                                                          
  "event": {                                                                                                                                                                                                                                  
    "module": "kubernetes",                                                                                                                                                                                                                   
    "duration": 162891130,                                                                                                                                                                                                                    
    "dataset": "kubernetes.node"                                                                                                                                                                                                              
  },                                                                                                                                                                                                                                          
  "kubernetes": {                                                                                                                                                                                                                             
    "node": {                                                                                                                                                                                                                                 
      "name": "node1",                                                                                                                                                                                                                      
      "status": {                                                                                                                                                                                                                             
        "unschedulable": false,                                                                                                                                                                                                               
        "memorypressure": "false",                                                                                                                                                                                                            
        "diskpressure": "false",                                                                                                                                                                                                              
        "pidpressure": "false",                                                                                                                                                                                                               
        "ready": "true"                                                                                                                                                                                                                       
      }                                                                                                                                                                                                                                       
    }                                                                                                                                                                                                                                         
  },                                                                                                                                                                                                                                          
  "ecs": {                                                                                                                                                                                                                                    
    "version": "1.7.0"                                                                                                                                                                                                                        
  },  
...

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 16, 2021
@ChrsMark ChrsMark requested a review from jsoriano February 16, 2021 12:34
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24057 opened

  • Start Time: 2021-02-16T12:34:59.140+0000

  • Duration: 34 min 8 sec

  • Commit: 85359a3

Test stats 🧪

Test Results
Failed 0
Passed 8658
Skipped 2122
Total 10780

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8658
Skipped 2122
Total 10780

@ChrsMark ChrsMark merged commit 7085358 into elastic:7.x Feb 16, 2021
@zube zube bot removed the [zube]: Done label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants