Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #24021 to 7.x: Syslog system tests: be more forgiving #24042

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

urso
Copy link

@urso urso commented Feb 15, 2021

Cherry-pick of PR #24021 to 7.x branch. Original message:

  • Fix Flaky Test

What does this PR do?

Update the syslog system tests in filebeat to check for a message prefix only.

Why is it important?

The assert function did require the message ID "0" to be added. The syslog tests increase counter per message. Due asserting the message ID we did require the UDP test to never drop the first message, but drop as many other message as is possible. By checking for the prefix only the test succeeds if at least a single UDP message will be received improving the chance of the test to succeed.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@urso urso added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Feb 15, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 15, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24042 opened

  • Start Time: 2021-02-15T15:47:00.293+0000

  • Duration: 41 min 51 sec

  • Commit: 2ec88f2

Test stats 🧪

Test Results
Failed 0
Passed 6172
Skipped 998
Total 7170

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6172
Skipped 998
Total 7170

@urso urso merged commit 44efc6f into elastic:7.x Feb 15, 2021
@urso urso deleted the backport_24021_7.x branch February 15, 2021 19:14
@zube zube bot removed the [zube]: Done label May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants