Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23956 to 7.x: Pass GO_VERSION to install-go command in make release #23962

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Feb 10, 2021

Cherry-pick of PR #23956 to 7.x branch. Original message:

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 10, 2021
@botelastic
Copy link

botelastic bot commented Feb 10, 2021

This pull request doesn't have a Team:<team> label.

Makefile Outdated
@@ -220,6 +220,8 @@ release-manager-snapshot:
.PHONY: release-manager-release
release-manager-release:
./dev-tools/run_with_go_ver $(MAKE) release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this duplicated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for catching it.

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport looks ok

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 10, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23962 updated

  • Start Time: 2021-02-10T15:43:57.828+0000

  • Duration: 11 min 28 sec

  • Commit: aa17dab

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@kvch kvch force-pushed the backport_23956_7.x branch from 65ae315 to 7d75de4 Compare February 10, 2021 15:31
@kvch kvch force-pushed the backport_23956_7.x branch from 7d75de4 to aa17dab Compare February 10, 2021 15:43
@kvch kvch merged commit 9ccf51e into elastic:7.x Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants