Remove unused reviewdog dependency #23959

kvch · 2021-02-10T10:08:47Z

Reviewdog was used a long time ago, but we still list it as a dependency. Not anymore.

michalpristas

look ok

elasticmachine · 2021-02-10T11:17:22Z

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #23959 updated
Start Time: 2021-02-10T10:17:40.580+0000
Duration: 59 min 57 sec
Commit: 764e8ae

Test stats 🧪

Test	Results
Failed	0
Passed	45794
Skipped	4762
Total	50556

Trends 🧪

Steps errors

Expand to view the steps failures

`Building Beats » Beats Packaging » PR-23959`

Took 0 min 0 sec . View more details on here

Log output

Expand to view the last 100 lines of log output

[2021-02-10T11:16:08.527Z] 16.92s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_260_snort
[2021-02-10T11:16:08.527Z] 16.04s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_065_o365
[2021-02-10T11:16:08.527Z] 11.01s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_196_cisco
[2021-02-10T11:16:08.527Z] 10.86s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_090_ibmmq
[2021-02-10T11:16:08.527Z] 10.77s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_088_ibmmq
[2021-02-10T11:16:08.527Z] 10.55s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_208_cisco
[2021-02-10T11:16:08.527Z] 10.43s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_108_panw
[2021-02-10T11:16:08.527Z] 10.42s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_105_panw
[2021-02-10T11:16:08.527Z] 10.38s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_107_panw
[2021-02-10T11:16:08.527Z] 10.16s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_009_gcp
[2021-02-10T11:16:08.527Z] 10.10s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_030_oracle
[2021-02-10T11:16:08.527Z] 10.04s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_006_zscaler
[2021-02-10T11:16:08.527Z] 9.99s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_087_juniper
[2021-02-10T11:16:08.527Z] 9.88s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_005_tomcat
[2021-02-10T11:16:08.527Z] 9.78s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_014_oracle
[2021-02-10T11:16:08.527Z] 9.78s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_080_juniper
[2021-02-10T11:16:08.527Z] 9.75s call     x-pack/filebeat/tests/system/test_xpack_modules.py::XPackTest::test_fileset_file_103_f5
[2021-02-10T11:16:08.528Z] ======================= 306 passed in 1448.23s (0:24:08) =======================
[2021-02-10T11:16:08.786Z] >> python test: Integration Testing Complete
[2021-02-10T11:16:12.560Z] Client: Docker Engine - Community
[2021-02-10T11:16:12.560Z]  Version:           20.10.3
[2021-02-10T11:16:12.560Z]  API version:       1.41
[2021-02-10T11:16:12.560Z]  Go version:        go1.13.15
[2021-02-10T11:16:12.560Z]  Git commit:        48d30b5
[2021-02-10T11:16:12.560Z]  Built:             Fri Jan 29 14:33:13 2021
[2021-02-10T11:16:12.560Z]  OS/Arch:           linux/amd64
[2021-02-10T11:16:12.560Z]  Context:           default
[2021-02-10T11:16:12.560Z]  Experimental:      true
[2021-02-10T11:16:12.560Z] 
[2021-02-10T11:16:12.560Z] Server: Docker Engine - Community
[2021-02-10T11:16:12.560Z]  Engine:
[2021-02-10T11:16:12.561Z]   Version:          20.10.3
[2021-02-10T11:16:12.561Z]   API version:      1.41 (minimum version 1.12)
[2021-02-10T11:16:12.561Z]   Go version:       go1.13.15
[2021-02-10T11:16:12.561Z]   Git commit:       46229ca
[2021-02-10T11:16:12.561Z]   Built:            Fri Jan 29 14:31:25 2021
[2021-02-10T11:16:12.561Z]   OS/Arch:          linux/amd64
[2021-02-10T11:16:12.561Z]   Experimental:     false
[2021-02-10T11:16:12.561Z]  containerd:
[2021-02-10T11:16:12.561Z]   Version:          1.4.3
[2021-02-10T11:16:12.561Z]   GitCommit:        269548fa27e0089a8b8278fc4fc781d7f65a939b
[2021-02-10T11:16:12.561Z]  runc:
[2021-02-10T11:16:12.561Z]   Version:          1.0.0-rc92
[2021-02-10T11:16:12.561Z]   GitCommit:        ff819c7e9184c13b7c2607fe6c30ae19403a7aff
[2021-02-10T11:16:12.561Z]  docker-init:
[2021-02-10T11:16:12.561Z]   Version:          0.19.0
[2021-02-10T11:16:12.561Z]   GitCommit:        de40ad0
[2021-02-10T11:16:12.561Z] Unable to find image 'alpine:3.4' locally
[2021-02-10T11:16:13.126Z] 3.4: Pulling from library/alpine
[2021-02-10T11:16:13.384Z] c1e54eec4b57: Pulling fs layer
[2021-02-10T11:16:13.641Z] c1e54eec4b57: Verifying Checksum
[2021-02-10T11:16:13.641Z] c1e54eec4b57: Download complete
[2021-02-10T11:16:13.899Z] c1e54eec4b57: Pull complete
[2021-02-10T11:16:13.899Z] Digest: sha256:b733d4a32c4da6a00a84df2ca32791bb03df95400243648d8c539e7b4cce329c
[2021-02-10T11:16:13.899Z] Status: Downloaded newer image for alpine:3.4
[2021-02-10T11:16:16.099Z] + python .ci/scripts/pre_archive_test.py
[2021-02-10T11:16:18.097Z] Copy ./x-pack/filebeat/build into build/x-pack/filebeat/build
[2021-02-10T11:16:18.110Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-23959/src/github.com/elastic/beats/build
[2021-02-10T11:16:18.464Z] + rm -rf ve
[2021-02-10T11:16:18.464Z] + find . -type d -name vendor -exec rm -r {} ;
[2021-02-10T11:16:18.554Z] Recording test results
[2021-02-10T11:16:22.595Z] [Checks API] No suitable checks publisher found.
[2021-02-10T11:16:23.018Z] Client: Docker Engine - Community
[2021-02-10T11:16:23.018Z]  Version:           20.10.3
[2021-02-10T11:16:23.018Z]  API version:       1.41
[2021-02-10T11:16:23.018Z]  Go version:        go1.13.15
[2021-02-10T11:16:23.018Z]  Git commit:        48d30b5
[2021-02-10T11:16:23.018Z]  Built:             Fri Jan 29 14:33:13 2021
[2021-02-10T11:16:23.018Z]  OS/Arch:           linux/amd64
[2021-02-10T11:16:23.018Z]  Context:           default
[2021-02-10T11:16:23.018Z]  Experimental:      true
[2021-02-10T11:16:23.018Z] 
[2021-02-10T11:16:23.018Z] Server: Docker Engine - Community
[2021-02-10T11:16:23.018Z]  Engine:
[2021-02-10T11:16:23.018Z]   Version:          20.10.3
[2021-02-10T11:16:23.018Z]   API version:      1.41 (minimum version 1.12)
[2021-02-10T11:16:23.018Z]   Go version:       go1.13.15
[2021-02-10T11:16:23.018Z]   Git commit:       46229ca
[2021-02-10T11:16:23.018Z]   Built:            Fri Jan 29 14:31:25 2021
[2021-02-10T11:16:23.018Z]   OS/Arch:          linux/amd64
[2021-02-10T11:16:23.018Z]   Experimental:     false
[2021-02-10T11:16:23.018Z]  containerd:
[2021-02-10T11:16:23.018Z]   Version:          1.4.3
[2021-02-10T11:16:23.018Z]   GitCommit:        269548fa27e0089a8b8278fc4fc781d7f65a939b
[2021-02-10T11:16:23.018Z]  runc:
[2021-02-10T11:16:23.018Z]   Version:          1.0.0-rc92
[2021-02-10T11:16:23.018Z]   GitCommit:        ff819c7e9184c13b7c2607fe6c30ae19403a7aff
[2021-02-10T11:16:23.018Z]  docker-init:
[2021-02-10T11:16:23.018Z]   Version:          0.19.0
[2021-02-10T11:16:23.018Z]   GitCommit:        de40ad0
[2021-02-10T11:16:34.743Z] Scheduling project: Beats » Beats Packaging » PR-23959
[2021-02-10T11:16:34.817Z] [INFO] Can not determine redirect link!!!
[2021-02-10T11:16:35.820Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-23959/src/github.com/elastic/beats
[2021-02-10T11:16:36.839Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-23959
[2021-02-10T11:16:36.954Z] [INFO] getVaultSecret: Getting secrets
[2021-02-10T11:16:37.058Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-02-10T11:16:38.081Z] + chmod 755 generate-build-data.sh
[2021-02-10T11:16:38.081Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-23959/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-23959/runs/2 FAILURE 3537236
[2021-02-10T11:16:38.331Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-23959/runs/2/steps/?limit=10000 -o steps-info.json
[2021-02-10T11:16:43.547Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-23959/runs/2/tests/?status=FAILED -o tests-errors.json

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test	Results
Failed	0
Passed	45794
Skipped	4762
Total	50556

(cherry picked from commit ac60dcb)

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 10, 2021

kvch added the needs_backport PR is waiting to be backported to other branches. label Feb 10, 2021

Remove reviewdog

764e8ae

kvch force-pushed the remove-review-dog branch from a7da91c to 764e8ae Compare February 10, 2021 10:16

kvch requested a review from a team as a code owner February 10, 2021 10:16

botelastic bot added Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 10, 2021

michalpristas approved these changes Feb 10, 2021

View reviewed changes

kvch merged commit ac60dcb into elastic:master Feb 10, 2021

kvch added a commit to kvch/beats that referenced this pull request Feb 10, 2021

Remove unused dependency: reviewdog (elastic#23959)

2b59925

(cherry picked from commit ac60dcb)

kvch mentioned this pull request Feb 10, 2021

Cherry-pick #23959 to 7.x: Remove unused reviewdog dependency #23963

Merged

kvch added v7.12.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 10, 2021

kvch added a commit that referenced this pull request Feb 10, 2021

Remove unused dependency: reviewdog (#23959) (#23963)

347b179

(cherry picked from commit ac60dcb)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unused reviewdog dependency #23959

Remove unused reviewdog dependency #23959

kvch commented Feb 10, 2021

michalpristas left a comment

elasticmachine commented Feb 10, 2021

Build stats

Test stats 🧪

Trends 🧪

`Building Beats » Beats Packaging » PR-23959`

Test stats 🧪

Remove unused reviewdog dependency #23959

Remove unused reviewdog dependency #23959

Conversation

kvch commented Feb 10, 2021

michalpristas left a comment

Choose a reason for hiding this comment

elasticmachine commented Feb 10, 2021

💔 Build Failed

Build stats

Test stats 🧪

Trends 🧪

Steps errors

Building Beats » Beats Packaging » PR-23959

Log output

💚 Flaky test report

Test stats 🧪

`Building Beats » Beats Packaging » PR-23959`