Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23724 to 7.x: [Filebeat] add RFC6587 framing support #23784

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Feb 1, 2021

Cherry-pick of PR #23724 to 7.x branch. Original message:

What does this PR do?

Adds support for RFC6587 framing.

  • Adds new config option "framing" for tcp & unix inputs
  • supported options are "delimiter" & rfc6587
  • delimiter is current option of newline or custom character(s)
    delimiter
  • rfc6587 adds support for octet counting and non-transparent framing
    as described in RFC6587
  • rfc6587 supports changing of framing on a frame by frame basis
  • Default is "delimiter"

Why is it important?

  • Required for Syslog inside TLS
  • Required for some RFC6587 compliant Syslog clients

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

mage test

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 1, 2021
- Adds new config option "framing"
- supported options are "delimiter" & rfc6587
- delimiter is current option of newline or custom character(s)
  delimiter
- rfc6587 adds support for octet counting and non-transparent framing
  as described in RFC6587
- rfc6587 supports changing of framing on a frame by frame basis
- Default is "delimiter"

Closes elastic#23663

(cherry picked from commit 5cb370e)
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23784 updated

    • Start Time: 2021-02-01T15:12:55.082+0000
  • Duration: 45 min 23 sec

  • Commit: 5fb33c9

Test stats 🧪

Test Results
Failed 0
Passed 12856
Skipped 2047
Total 14903

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 12856
Skipped 2047
Total 14903

@leehinman leehinman merged commit dbd431c into elastic:7.x Feb 1, 2021
@leehinman leehinman deleted the backport_23724_7.x branch February 1, 2021 20:58
@zube zube bot removed the [zube]: Done label May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants