-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enrich k8s state service events & add selector meta #23730
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <[email protected]>
Pinging @elastic/integrations (Team:Integrations) |
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
jsoriano
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Feb 2, 2021
(cherry picked from commit 1f38fff)
6 tasks
ChrsMark
added a commit
that referenced
this pull request
Feb 2, 2021
This was referenced Apr 20, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
kubernetes
Enable builds in the CI for kubernetes
needs_reviewer
PR needs to be assigned a reviewer
review
Team:Integrations
Label for the Integrations team
test-plan
Add this PR to be manual test plan
test-plan-added
This PR has been added to the test plan
v7.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
state_service
metrics so as to enrich metrics with Service objects metadata.ServiceMetadataGenerator
to enrich Service related events and not the genericResourceMetadataGenerator
ServiceMetadataGenerator
so as to includeselector
information (if exist) for a Service object.Note that with this implementation
selector
's key:val maps are added similarly withlabels
likekubernetes.service.selectors.*
but we can add them differently if Metrics UI requires that, @sorantis just let me know what you think.Why is it important?
So as to properly enrich
state_service
events with Service metadata and includeselector
information in these metadata.Example:
This service will be enriched with
kubernetes.service.selectors.app: MyApp
which will give us to the option to correlate the service with all the pods that are selected/exposed by this service and are labeled withkubernetes.labels.app: MyApp
.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
kube_state_metrics
and specifically usingstate_service
metricset.Related issues