Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Minor updates to Kubernetes and Heartbeat docs #23712

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

EamonnTP
Copy link

@EamonnTP EamonnTP commented Jan 27, 2021

Summary

This PR contains two minor updates to the Metricbeat Kubernetes module doc and the Heartbeat Getting Started doc.

HTML Preview

NOTE: Running mage fmt update to update the Kubernetes doc didn't work for me. I ran make clean and then make update, which seemed to work fine.

@EamonnTP EamonnTP added docs Team:Services (Deprecated) Label for the former Integrations-Services team v7.10.0 Team:Docs Label for the Observability docs team v7.11.0 labels Jan 27, 2021
@EamonnTP EamonnTP requested review from a team January 27, 2021 12:33
@EamonnTP EamonnTP self-assigned this Jan 27, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 27, 2021
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Incidentally I usually run make clean followed by make update for doc-only updates, too.

Comment on lines +65 to +66
dash (-). The following example configures Heartbeat to use three monitors: an
`icmp` monitor, a `tcp` monitor, and an `http` monitor.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂 😂 You did it!

@EamonnTP EamonnTP merged commit 1241622 into elastic:master Jan 28, 2021
@EamonnTP EamonnTP deleted the update-example-content branch January 28, 2021 12:46
EamonnTP pushed a commit to EamonnTP/beats that referenced this pull request Jan 28, 2021
EamonnTP pushed a commit to EamonnTP/beats that referenced this pull request Jan 28, 2021
EamonnTP pushed a commit to EamonnTP/beats that referenced this pull request Jan 28, 2021
EamonnTP pushed a commit that referenced this pull request Jan 28, 2021
EamonnTP pushed a commit that referenced this pull request Jan 28, 2021
EamonnTP pushed a commit that referenced this pull request Jan 28, 2021
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Team:Docs Label for the Observability docs team Team:Services (Deprecated) Label for the former Integrations-Services team v7.10.0 v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants