Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23673 to 7.x: Swap ECS 1.7 experimental schema with non-experimental to revert wildcard changes #23700

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

andrewstucki
Copy link

@andrewstucki andrewstucki commented Jan 26, 2021

Cherry-pick of PR #23673 to 7.x branch. Original message:

What does this PR do?

This PR changes the experimental ECS 1.7 schema that we were going to use in 7.11 to be the ECS 1.7 non-experimental version. This coincides with the Elasticsearch performance regressions that we saw on some widely used filebeat modules as mentioned in #23671. The fallback logic introduced to support wildcard fields can stay since the schema itself is switching back from wildcard to keyword. The intent is to proceed at a more judicious pace with wildcard adoption in coming releases.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

…card changes (elastic#23673)

* Swap ECS 1.7 experimental schema with non-experimental to revert wildcard changes

* Add back in user.effective.* fields to auditd integrations due to no longer using experimental schema

(cherry picked from commit 0f50eb7)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 26, 2021
@andrewstucki andrewstucki requested a review from a team January 26, 2021 21:31
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewstucki andrewstucki merged commit d1aa3ff into elastic:7.x Jan 26, 2021
@andrewstucki andrewstucki deleted the backport_23673_7.x branch January 26, 2021 23:23
@zube zube bot removed the [zube]: Done label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants