Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22584 to 7.x: Fix cassandra and icmp comments in packetbeat.yml #23645

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Jan 24, 2021

Cherry-pick of PR #22584 to 7.x branch. Original message:

  • Enhancement
  • Docs

What does this PR do?

Fix and Uniform comments in packetbeat.yml

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

* Uniform cassandra comment in packetbeat.yml

* Fix icmp comment in packetbeat.yml

* Uniform SIP comment in packetbeat.yml

* Update the config templates

Co-authored-by: Andrew Kroh <[email protected]>
(cherry picked from commit 6cad281)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 24, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 24, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 24, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user Victor Martinez

    • Start Time: 2021-01-25T12:07:26.072+0000
  • Duration: 26 min 52 sec

  • Commit: 06e33c6

Test stats 🧪

Test Results
Failed 0
Passed 1081
Skipped 10
Total 1091

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1081
Skipped 10
Total 1091

@andrewkroh andrewkroh merged commit b319c86 into elastic:7.x Jan 25, 2021
@zube zube bot removed the [zube]: Done label Apr 26, 2021
@andrewkroh andrewkroh deleted the backport_22584_7.x branch January 14, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants