Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Fixed nil pointer during unenroll #23609

Merged
merged 5 commits into from
Jan 21, 2021

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Jan 21, 2021

What does this PR do?

Fixes issue with unenroll serialization when nil pointer prevented unenrollment to be finished and caused agent to get into restart loop

Why is it important?

Makes agent unusable after unenroll. Unenroll is not acked so agent appears online

Fixes: #23593

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added bug needs_backport PR is waiting to be backported to other branches. labels Jan 21, 2021
@michalpristas michalpristas self-assigned this Jan 21, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Ingest Management labels Jan 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 21, 2021
@michalpristas michalpristas changed the title fixed nil pointer during unenroll [Ingest Manager] Fixed nil pointer during unenroll Jan 21, 2021
@michalpristas michalpristas added the Team:Elastic-Agent Label for the Agent team label Jan 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 21, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23609 updated

    • Start Time: 2021-01-21T12:32:46.844+0000
  • Duration: 23 min 16 sec

  • Commit: 22ffea7

Test stats 🧪

Test Results
Failed 0
Passed 1458
Skipped 4
Total 1462

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1458
Skipped 4
Total 1462

@michalpristas
Copy link
Contributor Author

/package

@ph
Copy link
Contributor

ph commented Jan 21, 2021

@michalpristas Is there an issue that should be linked to this PR?

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@michalpristas michalpristas merged commit 7bdbf28 into elastic:master Jan 21, 2021
michalpristas added a commit to michalpristas/beats that referenced this pull request Jan 21, 2021
[Ingest Manager] Fixed nil pointer during unenroll (elastic#23609)
michalpristas added a commit that referenced this pull request Jan 22, 2021
[Ingest Manager] Fixed nil pointer during unenroll (#23609)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs_backport PR is waiting to be backported to other branches. Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unenrolling Agent e2e-test fails - increasing timeout often passes the test, may have performance issue, etc
4 participants