Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix CHANGELOG links #23427

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Jan 11, 2021

What does this PR do?

This PR fixes documentation changelog links by escaping the ellipsis in the GitHub URL. This is required for Asciidoctor to build the link correctly. Noticed in #23416.

Why is it important?

Because 404s are no fun.

Testing

Compare the current changelog links with the changelog links in this PR.

@bmorelli25 bmorelli25 requested a review from a team January 11, 2021 22:29
@bmorelli25 bmorelli25 self-assigned this Jan 11, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 11, 2021
@bmorelli25 bmorelli25 added the Team:Docs Label for the Observability docs team label Jan 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 11, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23427 opened

  • Start Time: 2021-01-11T22:30:29.028+0000

  • Duration: 20 min 13 sec

❕ Flaky test report

No test was executed to be analysed.

@bmorelli25 bmorelli25 merged commit 2d2d9a8 into elastic:master Jan 12, 2021
@bmorelli25 bmorelli25 deleted the fix-changelog-links branch January 12, 2021 16:35
bmorelli25 added a commit to bmorelli25/beats that referenced this pull request Jan 12, 2021
# Conflicts:
#	CHANGELOG-developer.asciidoc
#	CHANGELOG.asciidoc
bmorelli25 added a commit to bmorelli25/beats that referenced this pull request Jan 12, 2021
# Conflicts:
#	CHANGELOG-developer.asciidoc
#	CHANGELOG.asciidoc
bmorelli25 added a commit that referenced this pull request Jan 12, 2021
bmorelli25 added a commit that referenced this pull request Jan 12, 2021
bmorelli25 added a commit that referenced this pull request Jan 12, 2021
bmorelli25 added a commit to bmorelli25/beats that referenced this pull request Jan 12, 2021
# Conflicts:
#	CHANGELOG-developer.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Docs Label for the Observability docs team v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants