-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auditbeat] Fix docs and config for arm builds #23381
Merged
fearful-symmetry
merged 4 commits into
elastic:master
from
fearful-symmetry:fix-auditbeat-arm-config
Jan 11, 2021
Merged
[Auditbeat] Fix docs and config for arm builds #23381
fearful-symmetry
merged 4 commits into
elastic:master
from
fearful-symmetry:fix-auditbeat-arm-config
Jan 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jan 6, 2021
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jan 6, 2021
Collaborator
adriansr
suggested changes
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling this!
adriansr
approved these changes
Jan 11, 2021
3 tasks
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Jan 11, 2021
* fix docs and config for arm builds * add changelog * include 386 (cherry picked from commit 5f4c725)
3 tasks
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Jan 11, 2021
* fix docs and config for arm builds * add changelog * include 386 (cherry picked from commit 5f4c725)
fearful-symmetry
added a commit
that referenced
this pull request
Jan 12, 2021
fearful-symmetry
added a commit
that referenced
this pull request
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It looks like the
socket
module isn't supported on ARM. Here we're adding another conditional to skip printing it in the config, and adding a note to the docs. I've asked @adriansr to review this, since I'm not sure if there's other modules we'll want to exclude.Why is it important?
The socket module is enabled by default, which is an issue on ARM builds where it isn't supported.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues