Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auditbeat] Fix docs and config for arm builds #23381

Merged

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Jan 6, 2021

What does this PR do?

It looks like the socket module isn't supported on ARM. Here we're adding another conditional to skip printing it in the config, and adding a note to the docs. I've asked @adriansr to review this, since I'm not sure if there's other modules we'll want to exclude.

Why is it important?

The socket module is enabled by default, which is an issue on ARM builds where it isn't supported.

Checklist

  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@fearful-symmetry fearful-symmetry requested review from adriansr and a team January 6, 2021 23:11
@fearful-symmetry fearful-symmetry self-assigned this Jan 6, 2021
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner January 6, 2021 23:11
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 6, 2021
@fearful-symmetry fearful-symmetry added the Team:Integrations Label for the Integrations team label Jan 6, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 6, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 6, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23381 updated

  • Start Time: 2021-01-07T20:22:56.476+0000

  • Duration: 24 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 232
Skipped 33
Total 265

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 232
Skipped 33
Total 265

Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this!

x-pack/auditbeat/module/system/_meta/config.yml.tmpl Outdated Show resolved Hide resolved
@fearful-symmetry fearful-symmetry merged commit 5f4c725 into elastic:master Jan 11, 2021
fearful-symmetry added a commit to fearful-symmetry/beats that referenced this pull request Jan 11, 2021
* fix docs and config for arm builds

* add changelog

* include 386

(cherry picked from commit 5f4c725)
fearful-symmetry added a commit to fearful-symmetry/beats that referenced this pull request Jan 11, 2021
* fix docs and config for arm builds

* add changelog

* include 386

(cherry picked from commit 5f4c725)
fearful-symmetry added a commit that referenced this pull request Jan 12, 2021
* fix docs and config for arm builds

* add changelog

* include 386

(cherry picked from commit 5f4c725)
fearful-symmetry added a commit that referenced this pull request Jan 12, 2021
* fix docs and config for arm builds

* add changelog

* include 386

(cherry picked from commit 5f4c725)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants