Cherry-pick #23183 to 7.x: Add nested field yml support in elasticsearch template rendering #23187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stic#23183) * Add nested field yml support in elasticsearch template rendering * Handle empty properties * Update changelog (cherry picked from commit ba7dbb6)
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
|
Anyone know what's up with the cross-document linkage failure in CI? Looks like it's related to the ECS 1.8 release? Not entirely sure how to fix it. |
leehinman
approved these changes
Dec 16, 2020
added 2 commits
December 16, 2020 23:58
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
| Test | Results |
|---|---|
| Failed | 0 |
| Passed | 17462 |
| Skipped | 1408 |
| Total | 18870 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #23183 to 7.x branch. Original message:
What does this PR do?
It looks like we don't handle subfields specified in
nestedfields properly. Here's the relevant Elasticsearch documentation:https://www.elastic.co/guide/en/elasticsearch/reference/current/nested.html
Currently it doesn't look like we use any non-dynamically mapped
nestedfields in ourfields.ymlspecifications, so I'm fine doing this for the 7.12 release rather than 7.11.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related Issues
CC: @dcode