Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vsphere.datastore.capacity.used.pct value by removing *100 #23148

Merged
merged 4 commits into from
Dec 16, 2020
Merged

Fix vsphere.datastore.capacity.used.pct value by removing *100 #23148

merged 4 commits into from
Dec 16, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Dec 15, 2020

What does this PR do?

This PR is to change vsphere.datastore.capacity.used.pct from int64 to float64, make sure the value is between 0-1.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 15, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Dec 15, 2020
@kaiyan-sheng kaiyan-sheng added bug needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team labels Dec 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 15, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 15, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23148 updated

  • Start Time: 2020-12-15T19:36:09.749+0000

  • Duration: 54 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 2295
Skipped 510
Total 2805

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 16 sec . View more details on here

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2295
Skipped 510
Total 2805

@kaiyan-sheng kaiyan-sheng merged commit 1e9b07c into elastic:master Dec 16, 2020
@kaiyan-sheng kaiyan-sheng deleted the vsphere_used_pct branch December 16, 2020 14:29
@kaiyan-sheng kaiyan-sheng added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 16, 2020
kaiyan-sheng added a commit that referenced this pull request Dec 17, 2020
kaiyan-sheng added a commit that referenced this pull request Dec 17, 2020
…alue by removing *100 (#23168)

(cherry picked from commit 1e9b07c)
kaiyan-sheng added a commit that referenced this pull request Dec 17, 2020
…lue by removing *100 (#23167)

(cherry picked from commit 1e9b07c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug review Team:Platforms Label for the Integrations - Platforms team v7.10.2 v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metricbeat] vsphere.datastore.capacity.used.pct with ECS format issue
3 participants